chore: Allow PuLP 3.1#3542
Merged
johanneskoester merged 1 commit intosnakemake:mainfrom Apr 24, 2025
Merged
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
johanneskoester
approved these changes
Apr 24, 2025
Contributor
|
THanks! |
johanneskoester
pushed a commit
that referenced
this pull request
Jun 3, 2025
<!--Add a description of your PR here--> Similar to #3542. Now the current version of PuLP is [3.2.1](https://github.com/coin-or/pulp/releases/tag/3.2.1). Nothing in the changes [from 3.1.1 to 3.2.1](coin-or/pulp@3.1.1...3.2.1) seems like it should cause any obvious problems for Snakemake, so let’s try to keep up with the latest PuLP releases. ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
<!--Add a description of your PR here--> This is a follow-up to snakemake#3466, which allowed PuLP 3.0. Now the current version is [3.1.1](https://github.com/coin-or/pulp/releases/tag/3.1.1). Nothing in the changes [from 3.0.2 to 3.1.0](coin-or/pulp@3.0.2...3.1.0) seems like it should cause any obvious problems for Snakemake, so let’s try to keep up with the latest PuLP releases. ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
<!--Add a description of your PR here--> Similar to snakemake#3542. Now the current version of PuLP is [3.2.1](https://github.com/coin-or/pulp/releases/tag/3.2.1). Nothing in the changes [from 3.1.1 to 3.2.1](coin-or/pulp@3.1.1...3.2.1) seems like it should cause any obvious problems for Snakemake, so let’s try to keep up with the latest PuLP releases. ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #3466, which allowed PuLP 3.0. Now the current version is 3.1.1. Nothing in the changes from 3.0.2 to 3.1.0 seems like it should cause any obvious problems for Snakemake, so let’s try to keep up with the latest PuLP releases.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).