fix: unify error logging in scheduler, fixing a missing attribute error for group jobs#3515
Merged
johanneskoester merged 1 commit intomainfrom Apr 7, 2025
Merged
fix: unify error logging in scheduler, fixing a missing attribute error for group jobs#3515johanneskoester merged 1 commit intomainfrom
johanneskoester merged 1 commit intomainfrom
Conversation
…or for group jobs
Contributor
📝 WalkthroughWalkthroughThe pull request refactors the error logging in the Changes
Sequence Diagram(s)sequenceDiagram
participant JS as JobScheduler
participant Job as Job Instance
JS->>+Job: Invoke log_error() on each job in self.failed
Job-->>-JS: Log error
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)`**/*.py`: Do not try to improve formatting. Do not suggest type annotations for functions that are defined inside of functions or methods. Do not suggest type annotation of the `s...
🧬 Code Definitions (1)src/snakemake/scheduler.py (1)
⏰ Context from checks skipped due to timeout of 90000ms (22)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
johanneskoester
pushed a commit
that referenced
this pull request
Apr 7, 2025
🤖 I have created a release *beep* *boop* --- ## [9.1.8](v9.1.7...v9.1.8) (2025-04-07) ### Bug Fixes * improve labelling of input and output files when logging rules ([#3516](#3516)) ([56203a4](56203a4)) * unify error logging in scheduler, fixing a missing attribute error for group jobs ([#3515](#3515)) ([245ec10](245ec10)) ### Documentation * activate gurubase AI ([#3517](#3517)) ([eaffc6e](eaffc6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
…or for group jobs (snakemake#3515) ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Revised error logging in the job scheduling process by removing distinctions based on job type. All failed jobs are now handled uniformly, leading to more consistent and clear error reporting. These changes facilitate improved diagnostics and system maintainability, ultimately supporting a transparent and reliable user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
kjohnsen
pushed a commit
to kjohnsen/snakemake
that referenced
this pull request
Dec 15, 2025
🤖 I have created a release *beep* *boop* --- ## [9.1.8](snakemake/snakemake@v9.1.7...v9.1.8) (2025-04-07) ### Bug Fixes * improve labelling of input and output files when logging rules ([snakemake#3516](snakemake#3516)) ([56203a4](snakemake@56203a4)) * unify error logging in scheduler, fixing a missing attribute error for group jobs ([snakemake#3515](snakemake#3515)) ([245ec10](snakemake@245ec10)) ### Documentation * activate gurubase AI ([snakemake#3517](snakemake#3517)) ([eaffc6e](snakemake@eaffc6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).Summary by CodeRabbit