Skip to content

fix: correctly report lineno#2584

Merged
johanneskoester merged 5 commits intosnakemake:testcase-syntaxerror-linenofrom
Hocnonsense:wrong_error_lineno
Jan 8, 2024
Merged

fix: correctly report lineno#2584
johanneskoester merged 5 commits intosnakemake:testcase-syntaxerror-linenofrom
Hocnonsense:wrong_error_lineno

Conversation

@Hocnonsense
Copy link
Copy Markdown
Contributor

Description

fix: #2583, #1256 and #2574

QC

maybe #2583

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@johanneskoester johanneskoester changed the base branch from main to testcase-syntaxerror-lineno January 8, 2024 08:22
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johanneskoester
Copy link
Copy Markdown
Contributor

Thanks a lot! I have added a testcase from PR #2583

@johanneskoester johanneskoester merged commit 967a0d7 into snakemake:testcase-syntaxerror-lineno Jan 8, 2024
@johanneskoester
Copy link
Copy Markdown
Contributor

The branch testcase-syntaxerror-lineno has been merged into main now, containing this PR and PR #2583.

@Hocnonsense Hocnonsense deleted the wrong_error_lineno branch January 8, 2024 10:05
johanneskoester pushed a commit that referenced this pull request Jan 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.1.0](v8.0.1...v8.1.0)
(2024-01-08)


### Features

* add --sdm short opt for --deployment
([#2551](#2551))
([fd8b4b0](fd8b4b0))


### Bug Fixes

* add mamba to docker image
([eb0c884](eb0c884))
* correctly report lineno
([#2584](#2584))
([967a0d7](967a0d7))
* move apptainer into separate env in docker image
([94e9e2c](94e9e2c))
* single line f-string format error in py3.12
([#2588](#2588))
([87c06c0](87c06c0))


### Documentation

* add note on google executor backends
([ff8683c](ff8683c))
* diff 7 and 8
([#2561](#2561))
([ba22e07](ba22e07))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Hocnonsense Hocnonsense self-assigned this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants