Skip to content

test: Add test for issue #1256 and #2574#2583

Merged
johanneskoester merged 1 commit intosnakemake:testcase-syntaxerror-linenofrom
dariober:test_issue1256
Jan 8, 2024
Merged

test: Add test for issue #1256 and #2574#2583
johanneskoester merged 1 commit intosnakemake:testcase-syntaxerror-linenofrom
dariober:test_issue1256

Conversation

@dariober
Copy link
Copy Markdown
Contributor

@dariober dariober commented Jan 5, 2024

Description

Add test for issues #1256 and #2574.

The test Snakefile has a syntax error on line 9. Some versions of Snakemake, including 8.0.1, incorrectly report the error on line 20. I'm only submitting the test case, not the fix.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

The test Snakefile has a syntax error on line 9. Some versions of
Snakemake, including 8.0.1, incorrectly report the error on line 20
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dariober dariober changed the title Add test for issue #1256 and #2574 test: Add test for issue #1256 and #2574 Jan 5, 2024
@Hocnonsense Hocnonsense mentioned this pull request Jan 5, 2024
2 tasks
@johanneskoester johanneskoester changed the base branch from main to testcase-syntaxerror-lineno January 8, 2024 08:20
@johanneskoester
Copy link
Copy Markdown
Contributor

Thank you! I merge this into a temporary branch now, in order to include it in PR #2584.

@johanneskoester johanneskoester merged commit ab96f09 into snakemake:testcase-syntaxerror-lineno Jan 8, 2024
johanneskoester added a commit that referenced this pull request Jan 8, 2024
### Description

fix: #2583, #1256 and #2574

### QC
maybe #2583

* [ ] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
* [ ] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).

---------

Co-authored-by: Johannes Köster <[email protected]>
@dariober dariober deleted the test_issue1256 branch January 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants