feat: add --sdm short opt for --deployment#2551
Merged
johanneskoester merged 5 commits intosnakemake:mainfrom Jan 8, 2024
Merged
feat: add --sdm short opt for --deployment#2551johanneskoester merged 5 commits intosnakemake:mainfrom
johanneskoester merged 5 commits intosnakemake:mainfrom
Conversation
Contributor
|
Good idea, but I think I would prefer |
Member
Author
Done |
mbhall88
changed the title
Member
Author
|
@johanneskoester i didn’t really touch any code except to add the short option, so I don’t know why tests are failing… |
|
Member
Author
|
Ah it was because when I went from |
johanneskoester
approved these changes
Jan 8, 2024
Contributor
|
Thanks! |
johanneskoester
pushed a commit
that referenced
this pull request
Jan 8, 2024
🤖 I have created a release *beep* *boop* --- ## [8.1.0](v8.0.1...v8.1.0) (2024-01-08) ### Features * add --sdm short opt for --deployment ([#2551](#2551)) ([fd8b4b0](fd8b4b0)) ### Bug Fixes * add mamba to docker image ([eb0c884](eb0c884)) * correctly report lineno ([#2584](#2584)) ([967a0d7](967a0d7)) * move apptainer into separate env in docker image ([94e9e2c](94e9e2c)) * single line f-string format error in py3.12 ([#2588](#2588)) ([87c06c0](87c06c0)) ### Documentation * add note on google executor backends ([ff8683c](ff8683c)) * diff 7 and 8 ([#2561](#2561)) ([ba22e07](ba22e07)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new
--software-deployment-method/--deployment-method/--deploymentis probably a heavily used option for most users, so I think it would benefit from a shorthand option as it is quite verbose. Seems-mis available and is kind of related.I've also updated the docs with some references to this shorthand version and replaced some longform usage with the short option, ensuring it is made clear what the shorthand option is an alias for. Happy to change this though.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).