Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: snakemake/snakemake
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.14.1
Choose a base ref
...
head repository: snakemake/snakemake
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.14.3
Choose a head ref
  • 6 commits
  • 16 files changed
  • 6 contributors

Commits on Dec 4, 2025

  1. test: Improve logging tests (#3848)

    - Edits to `common` test module:
      - Added type annotations to many functions
      - Edits to `run()` function:
        - Documented and added type annotations for many arguments.
        - Allow `path` and `tmpdir` to be either string or `os.Pathlike`.
        - Removed unused `subpath` argument.
    - Updates to existing logging tests:
    - Added file to `test-all` Pixi task, I don't think it was actually
    being run before.
    - Added some helper functions to deduplicate code relating to counting
    log events.
    - Don't count exact number of `LOG_COUNTED` events (multiple jobs can be
    grouped under a single event), just assert at least one exists.
      - Completed `test_rule_failure` test, add expected log counts.
    - Run workflow in `test_logging_config` in temporary directory instead
    of current directory (this maybe should be using the same `run()`
    function as all the others, but isn't).
    - Added some more descriptive docstrings and type annotations to test
    functions.
    - Added new test for logging plugin.
    
    An issue I noticed that existed before this PR and I did not change: the
    `benchmark_extended` argument of the `run()` test function is used in
    some tests but its value is ignored in the function body.
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Tests**
    * Added centralized helpers to count and validate log events and
    refactored tests to use them.
    * Added a test logging plugin that emits structured JSONL events
    (including an initial logger_info record) for improved log capture and
    verification.
    
    * **Chores**
    * Introduced comprehensive type annotations and a new string/path type
    alias across test utilities for clearer typing and maintainability.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    ---------
    
    Co-authored-by: Cade Mirchandani <[email protected]>
    jlumpe and cademirch authored Dec 4, 2025
    Configuration menu
    Copy the full SHA
    cd265bb View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2025

  1. fix: correctly handle groups when retrieving storage input (#3861)

    <!--Add a description of your PR here-->
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Bug Fixes**
    * Improved handling of grouped workflow tasks when retrieving storage
    inputs, ensuring proper aggregation across all tasks within a group
    rather than treating them as a single unit.
      * Enhanced type safety with explicit parameter validation.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Dec 5, 2025
    Configuration menu
    Copy the full SHA
    8c818f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2025

  1. chore(main): release 9.14.2 (#3863)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [9.14.2](v9.14.1...v9.14.2)
    (2025-12-05)
    
    
    ### Bug Fixes
    
    * correctly handle groups when retrieving storage input
    ([#3861](#3861))
    ([8c818f4](8c818f4))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    snakemake-bot authored Dec 6, 2025
    Configuration menu
    Copy the full SHA
    babdf42 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2025

  1. fix: ensure that queue input jobs wait if the queue is still empty up…

    …on job creation (#3866)
    
    fixes #3852
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Bug Fixes**
    * Relaxed scheduling readiness checks to correctly handle pending queued
    input jobs and avoid spurious assertion errors.
    
    * **Refactor**
    * Simplified tracking of queue inputs for leaner, more reliable
    processing.
    
    * **Tests**
    * Updated queue-input test timing to align with the revised scheduling
    behavior.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Dec 7, 2025
    Configuration menu
    Copy the full SHA
    555ab6a View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2025

  1. fix: fix issues with cyclic dependencies when using the update and be…

    …fore_update flag (#3857)
    
    <!--Add a description of your PR here-->
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Bug Fixes**
    * Cycle detection now ignores cases involving before_update flags to
    avoid false-cycle reports.
    * Flag precedence corrected so update jobs take precedence over
    before_update when both apply.
    
    * **Tests**
    * Added tests and fixtures covering cyclic dependency scenarios,
    including a forced-rerun case, to validate the updated behavior.
    
    <sub>✏️ Tip: You can customize this high-level summary in your review
    settings.</sub>
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    ---------
    
    Co-authored-by: Johannes Koester <[email protected]>
    FelixMoelder and johanneskoester authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    21cc94e View commit details
    Browse the repository at this point in the history
  2. chore(main): release 9.14.3 (#3868)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [9.14.3](v9.14.2...v9.14.3)
    (2025-12-08)
    
    
    ### Bug Fixes
    
    * ensure that queue input jobs wait if the queue is still empty upon job
    creation ([#3866](#3866))
    ([555ab6a](555ab6a))
    * fix issues with cyclic dependencies when using the update and
    before_update flag
    ([#3857](#3857))
    ([21cc94e](21cc94e))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    snakemake-bot authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    02c1198 View commit details
    Browse the repository at this point in the history
Loading