Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: snakemake/snakemake
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.1.2
Choose a base ref
...
head repository: snakemake/snakemake
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.1.3
Choose a head ref
  • 3 commits
  • 6 files changed
  • 4 contributors

Commits on Mar 26, 2025

  1. fix: setup_logfile in setup logger to ensure logfile handler is added (

    …#3486)
    
    Fixes oversight that resulted in empty log files. Will add a test soon.
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    - **New Features**
    - Introduced a new test for verifying the existence and content of log
    files generated during execution.
    - Added a new workflow definition with rules for generating output
    files.
    
    - **Refactor**
    - Enhanced the logging system to ensure log files are created during
    setup and improved the cleanup process by detaching handlers.
    
    - **Bug Fixes**
    - Improved error handling during temporary directory cleanup, ensuring
    resources are properly released on Windows systems.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    ---------
    
    Co-authored-by: Johannes Köster <[email protected]>
    cademirch and johanneskoester authored Mar 26, 2025
    Configuration menu
    Copy the full SHA
    2ed13fc View commit details
    Browse the repository at this point in the history
  2. fix: pass correct local storage prefix in case an executor spawns an …

    …inner job (#3488)
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    - **Refactor**
    - Enhanced the job submission logic by clarifying the handling of local
    and remote execution modes, improving the transparency and
    maintainability of storage settings.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Mar 26, 2025
    Configuration menu
    Copy the full SHA
    1454ca1 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2025

  1. chore(main): release 9.1.3 (#3487)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [9.1.3](v9.1.2...v9.1.3)
    (2025-03-26)
    
    
    ### Bug Fixes
    
    * pass correct local storage prefix in case an executor spawns an inner
    job ([#3488](#3488))
    ([1454ca1](1454ca1))
    * setup_logfile in setup logger to ensure logfile handler is added
    ([#3486](#3486))
    ([2ed13fc](2ed13fc))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    snakemake-bot authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    17f0d9b View commit details
    Browse the repository at this point in the history
Loading