Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: snakemake/snakemake
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.28.0
Choose a base ref
...
head repository: snakemake/snakemake
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.29.0
Choose a head ref
  • 16 commits
  • 33 files changed
  • 4 contributors

Commits on Feb 14, 2025

  1. fix: sort results lexicographically by labels in their order of appea…

    …rance (#3293)
    
    <!--Add a description of your PR here-->
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - **Enhanced Results Display:** Results are now organized and sorted for
    clearer, more intuitive presentation.
    - **Improved Navigation:** Clicking the breadcrumb now takes you back to
    the main menu, streamlining the navigation experience.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Feb 14, 2025
    Configuration menu
    Copy the full SHA
    a19a0ac View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2025

  1. fix: add missing @conda annotations (#3298)

    The snakemake tests use the decorator `@conda` to check whether the
    `conda` executable is in the user `$PATH` and otherwise skips them.
    
    However, some annotations are missing and hence failing instead of being
    skipped without `conda`:
    
    ```
    tests/tests.py::test_conda_create_envs_only
    tests/tests.py::test_get_log_none
    tests/tests.py::test_get_log_both
    tests/tests.py::test_get_log_stderr
    tests/tests.py::test_get_log_stdout
    tests/tests.py::test_get_log_complex
    tests/tests.py::test_issue1046
    tests/tests.py::test_containerize
    ```
    
    This patch adds the missing decorator to those tests.
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **Tests**
    - Expanded automated test coverage to verify environment setup
    processes.
    - Added validations for logging behavior across multiple scenarios,
    ensuring robust handling of different output conditions.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    mschubert authored Feb 18, 2025
    Configuration menu
    Copy the full SHA
    0b541cc View commit details
    Browse the repository at this point in the history
  2. feat: provide mechanism to link between report items (snakemake.repor…

    …t_href, see docs) (#3224)
    
    <!--Add a description of your PR here-->
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    ## Release Notes
    
    - **New Features**
    - Enhanced reporting capabilities with new directives and methods for
    generating comprehensive HTML reports.
    - Introduced dynamic linking in reports and the ability to include file
    labels and categories.
    - Added new HTML report generation functionality with example workflows.
    - New functionality to manage report hyperlinks, improving navigation
    within reports.
    
    - **Bug Fixes**
    	- Improved error handling and user feedback during report generation.
    
    - **Tests**
    - Added new tests for report generation functionality to ensure
    reliability.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Feb 18, 2025
    Configuration menu
    Copy the full SHA
    a024e60 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2025

  1. Configuration menu
    Copy the full SHA
    7270eb3 View commit details
    Browse the repository at this point in the history
  2. restructure

    johanneskoester committed Feb 19, 2025
    Configuration menu
    Copy the full SHA
    508c196 View commit details
    Browse the repository at this point in the history
  3. docs

    johanneskoester committed Feb 19, 2025
    Configuration menu
    Copy the full SHA
    944c86a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    784e867 View commit details
    Browse the repository at this point in the history
  5. chore: use locally deployed minio instead of play.min.io for storage …

    …testing (#3304)
    
    <!--Add a description of your PR here-->
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    - **Chores**
    - Enhanced our CI workflow by configuring a local object storage service
    for improved testing reliability.
    
    - **Tests**
    - Updated storage settings to use local credentials for a more isolated
    test environment.
    - Added new tests to validate storage functionality across supported
    platforms, with specific handling for Windows.
    	- Expanded test coverage for storage-related features.
    
    - **Documentation**
    - Updated package version requirement for `sphinx` to address a
    temporary bug.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Feb 19, 2025
    Configuration menu
    Copy the full SHA
    4818b80 View commit details
    Browse the repository at this point in the history
  6. feat: toggles for binary labels in report (#3296)

    <!--Add a description of your PR here-->
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    - **New Features**
    - Introduced interactive toggle switches that let users dynamically
    filter and adjust result displays.
    - Added a new `Toggle` component for selecting between values using
    radio buttons.
    - Enhanced result display management with the `ToggleViewManager` and
    `ButtonViewManager` classes.
    - Integrated new JavaScript components into the report's HTML template
    for improved functionality.
    
    - **Bug Fixes**
    - Updated asset specifications for `tailwindcss` to ensure correct
    versioning and URL retrieval.
    
    - **Documentation**
    - Enhanced reporting documentation with recommendations for using labels
    and showcasing toggle switch functionality.
    
    - **Refactor**
    - Optimized the result view button behavior for a more intuitive and
    consistent user experience.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Feb 19, 2025
    Configuration menu
    Copy the full SHA
    7690998 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2025

  1. dbg

    johanneskoester committed Feb 21, 2025
    Configuration menu
    Copy the full SHA
    99ae9b2 View commit details
    Browse the repository at this point in the history
  2. chore: fix if syntax

    johanneskoester committed Feb 21, 2025
    Configuration menu
    Copy the full SHA
    9a3e29f View commit details
    Browse the repository at this point in the history
  3. fix

    johanneskoester committed Feb 21, 2025
    Configuration menu
    Copy the full SHA
    04f89d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2025

  1. fix: provide proper error messages if output file preparation (pipe, …

    …mkdir) fails (#3309)
    
    <!--Add a description of your PR here-->
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    johanneskoester authored Feb 27, 2025
    Configuration menu
    Copy the full SHA
    77ef176 View commit details
    Browse the repository at this point in the history
  2. fix: properly handle remote storage when waiting for pipes (#3317)

    Before it could fail with certain storage plugins (e.g. fs), in
    combination with local execution.
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - Refined file storage behavior by excluding certain flagged files from
    retention.
    - Enhanced file waiting functionality with an additional option for
    local file evaluation and clearer notifications when files are missing.
    - Upgraded job processing by tracking special outputs and providing
    improved error reporting for smoother operations.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Feb 27, 2025
    Configuration menu
    Copy the full SHA
    9f7e092 View commit details
    Browse the repository at this point in the history
  3. fix: record file extension (e.g. .tsv) in between workflow cache reco…

    …rds in order to avoid that files of the wrong format are erroneously returned by the cache. This will lead to some cache misses. But avoiding errors induced by the previous behavior of ignoring file extensions when seeking for cache records is more important. (#3314)
    
    <!--Add a description of your PR here-->
    
    ### QC
    <!-- Make sure that you can tick the boxes below. -->
    
    * [x] The PR contains a test case for the changes or the changes are
    already covered by an existing test case.
    * [x] The documentation (`docs/`) is updated to reflect the changes or
    this is not necessary (e.g. if the change does neither modify the
    language nor the behavior or functionalities of Snakemake).
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    - **New Features**
    - Improved caching of job outputs by incorporating file extensions. This
    update ensures that output files are more accurately identified and
    retrieved from the cache, reducing potential mismatches.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    johanneskoester authored Feb 27, 2025
    Configuration menu
    Copy the full SHA
    4912f00 View commit details
    Browse the repository at this point in the history
  4. chore(main): release 8.29.0 (#3294)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [8.29.0](v8.28.0...v8.29.0)
    (2025-02-27)
    
    
    ### Features
    
    * provide mechanism to link between report items (snakemake.report_href,
    see docs) ([#3224](#3224))
    ([a024e60](a024e60))
    * toggles for binary labels in report
    ([#3296](#3296))
    ([7690998](7690998))
    
    
    ### Bug Fixes
    
    * add missing [@conda](https://github.com/conda) annotations
    ([#3298](#3298))
    ([0b541cc](0b541cc))
    * properly handle remote storage when waiting for pipes
    ([#3317](#3317))
    ([9f7e092](9f7e092))
    * provide proper error messages if output file preparation (pipe, mkdir)
    fails ([#3309](#3309))
    ([77ef176](77ef176))
    * record file extension (e.g. .tsv) in between workflow cache records in
    order to avoid that files of the wrong format are erroneously returned
    by the cache. This will lead to some cache misses. But avoiding errors
    induced by the previous behavior of ignoring file extensions when
    seeking for cache records is more important.
    ([#3314](#3314))
    ([4912f00](4912f00))
    * sort results lexicographically by labels in their order of appearance
    ([#3293](#3293))
    ([a19a0ac](a19a0ac))
    
    
    ### Documentation
    
    * update best practices
    ([7270eb3](7270eb3))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored Feb 27, 2025
    Configuration menu
    Copy the full SHA
    beb9915 View commit details
    Browse the repository at this point in the history
Loading