fix: Don't attempt to parse TBDString resources (#2690)

twrightsman · johanneskoester · web-flow · commit f884b50eddf3 · 2024-02-15T10:15:41.000Z
### Description This fixes the `WorkflowError`s that occur when the resource parsing code tries to parse `TBDString`s during a dry run. This should fix #2575 and fix #2555. ### QC * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de>
diff --git a/snakemake/resources.py b/snakemake/resources.py
@@ -611,7 +611,11 @@ def infer_resources(name, value, resources: dict):
     """Infer resources from a given one, if possible."""
     from humanfriendly import parse_size, parse_timespan, InvalidTimespan, InvalidSize
 
-    if (name == "mem" or name == "disk") and isinstance(value, str):
+    if (
+        (name == "mem" or name == "disk")
+        and isinstance(value, str)
+        and not isinstance(value, TBDString)
+    ):
         inferred_name = f"{name}_mb"
         try:
             in_bytes = parse_size(value)
@@ -620,7 +624,11 @@ def infer_resources(name, value, resources: dict):
                 f"Cannot parse mem or disk value into size in MB for setting {inferred_name} resource: {value}"
             )
         resources[inferred_name] = max(int(round(in_bytes / 1024 / 1024)), 1)
-    elif name == "runtime" and isinstance(value, str):
+    elif (
+        name == "runtime"
+        and isinstance(value, str)
+        and not isinstance(value, TBDString)
+    ):
         try:
             resources["runtime"] = max(int(round(parse_timespan(value) / 60)), 1)
         except InvalidTimespan:
diff --git a/tests/test_resource_tbdstring/Snakefile b/tests/test_resource_tbdstring/Snakefile
@@ -0,0 +1,9 @@
+rule all:
+     input: "a.out"
+
+rule test1:
+     output: "a.out"
+     resources:
+        mem = lambda wildcards, attempt: f"{attempt}MB",
+        runtime = lambda wildcards, attempt: f"{attempt}m"
+     shell: "touch {output}"
diff --git a/tests/tests.py b/tests/tests.py
@@ -1980,6 +1980,13 @@ def test_resource_string_in_cli_or_profile():
     )
 
 
+def test_resource_tbdstring():
+    test_path = dpath("test_resource_tbdstring")
+    results_dir = Path(test_path) / "expected-results"
+    results_dir.mkdir(exist_ok=True)
+    run(test_path, executor="dryrun", check_results=False)
+
+
 def test_queue_input():
     run(dpath("test_queue_input"))
 
