fix: return set instead of list when just --quiet (#2829)

cademirch · web-flow · commit eeb57e26c4d8 · 2024-04-28T20:55:33.000+02:00
### Description Fixes #2825. `parse_quietness` should return a set since that is what `setup_logger()` expects. ### QC  * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
diff --git a/snakemake/cli.py b/snakemake/cli.py
@@ -1767,7 +1767,7 @@ def parse_args(argv):
 def parse_quietness(quietness) -> Set[Quietness]:
     if quietness is not None and len(quietness) == 0:
         # default case, set quiet to progress and rule
-        quietness = [Quietness.PROGRESS, Quietness.RULES]
+        quietness = {Quietness.PROGRESS, Quietness.RULES}
     else:
         quietness = Quietness.parse_choices_set(quietness)
     return quietness
diff --git a/snakemake/logging.py b/snakemake/logging.py
@@ -746,7 +746,7 @@ def setup_logger(
             quiet = set()
     elif not isinstance(quiet, set):
         raise ValueError(
-            "Unsupported value provided for quiet mode (either bool, None or list allowed)."
+            "Unsupported value provided for quiet mode (either bool, None or set allowed)."
         )
 
     logger.log_handler.extend(handler)

Original file line number	Diff line number	Diff line change
`@@ -746,7 +746,7 @@ def setup_logger(`
`746`	`746`	`quiet = set()`
`747`	`747`	`elif not isinstance(quiet, set):`
`748`	`748`	`raise ValueError(`
`749`		`- "Unsupported value provided for quiet mode (either bool, None or list allowed)."`
	`749`	`+ "Unsupported value provided for quiet mode (either bool, None or set allowed)."`
`750`	`750`	`)`
`751`	`751`
`752`	`752`	`logger.log_handler.extend(handler)`