fix: only trigger script with CODE label

Hocnonsense · Hocnonsense · commit c2dfa122a22d · 2025-08-25T23:43:25.000+08:00
diff --git a/src/snakemake/dag.py b/src/snakemake/dag.py
@@ -1447,15 +1447,15 @@ async def updated_input():
                             # for determining any other changes than file modification dates, as it will
                             # change after evaluating the input function of the job in the second pass.
 
-                            # The list comprehension is needed below in order to
-                            # collect all the async generator items before
-                            # applying any().
-                            reason.code_changed = any(
-                                [
-                                    f
-                                    async for f in job.outputs_older_than_script_or_notebook()
-                                ]
-                            )
+                            if RerunTrigger.CODE in self.workflow.rerun_triggers:
+                                # job metadata can be missed, but the separate scripts don't.
+                                # but it should not work if unwanted
+                                reason.code_changed = any(
+                                    [
+                                        f
+                                        async for f in job.outputs_older_than_script_or_notebook()
+                                    ]
+                                )
                             if not self.workflow.persistence.has_metadata(job):
                                 reason.no_metadata = True
                             elif self.workflow.persistence.has_outdated_metadata(job):
diff --git a/tests/common.py b/tests/common.py
@@ -13,7 +13,7 @@
 from os.path import join
 import tempfile
 import hashlib
-import urllib
+import urllib.request
 import pytest
 import glob
 import subprocess
diff --git a/tests/tests.py b/tests/tests.py
@@ -479,7 +479,19 @@ def test_empty_include():
 
 
 def test_script_python():
-    run(dpath("test_script_py"))
+    tmpdir = run(dpath("test_script_py"), cleanup=False)
+    outfile_path = os.path.join(tmpdir, "test.out")
+    outfile_timestamp_orig = os.path.getmtime(outfile_path)
+    # update timestamp but not contents of input file
+    script_file = os.path.join(tmpdir, "scripts/test.py")
+    os.utime(script_file)
+    run(
+        dpath("test_script_py"),
+        rerun_triggers=frozenset([RerunTrigger.MTIME]),
+        cleanup=False,
+    )
+    outfile_timestamp_new = os.path.getmtime(outfile_path)
+    assert outfile_timestamp_orig == outfile_timestamp_new
 
 
 @skip_on_windows  # Test relies on perl
