fix: edgecases of source deployment in case of remote execution (#3396)

jakevc · web-flow · commit 5da13be8f56e · 2025-03-14T10:21:12.000Z
Ensures sources are not uploaded on dry run, and they are cleaned up if
nothing to be done.

### QC
&lt;!-- Make sure that you can tick the boxes below. --&gt;

* [ ] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
* [ ] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).


&lt;!-- This is an auto-generated comment: release notes by coderabbit.ai
--&gt;
## Summary by CodeRabbit

- **Bug Fixes**
- Refined deployment processing to ensure that source uploads occur only
during active operations, preventing unintended actions during
simulation or when there are no tasks to process.
&lt;!-- end of auto-generated comment: release notes by coderabbit.ai --&gt;
diff --git a/src/snakemake/workflow.py b/src/snakemake/workflow.py
@@ -1263,6 +1263,8 @@ def execute(
                 and self.exec_mode == ExecMode.DEFAULT
                 and self.remote_execution_settings.job_deploy_sources
                 and not executor_plugin.common_settings.can_transfer_local_files
+                and not self.dryrun
+                and len(self.dag)
             )
             if should_deploy_sources:
                 # no shared FS, hence we have to upload the sources to the storage

Original file line number	Diff line number	Diff line change
`@@ -1263,6 +1263,8 @@ def execute(`
`1263`	`1263`	`and self.exec_mode == ExecMode.DEFAULT`
`1264`	`1264`	`and self.remote_execution_settings.job_deploy_sources`
`1265`	`1265`	`and not executor_plugin.common_settings.can_transfer_local_files`
	`1266`	`+ and not self.dryrun`
	`1267`	`+ and len(self.dag)`
`1266`	`1268`	`)`
`1267`	`1269`	`if should_deploy_sources:`
`1268`	`1270`	`# no shared FS, hence we have to upload the sources to the storage`