Applying requested changes for pull request

schrins · schrins · commit 259ed206527f · 2025-03-12T15:11:04.000+01:00
diff --git a/snakemake/cli.py b/snakemake/cli.py
@@ -2055,7 +2055,7 @@ def args_to_api(args, parser):
                         config=parse_config(args.config),
                         configfiles=args.configfile,
                         config_args=args.config,
-                        replace_workflow=args.replace_workflow_config,
+                        replace_workflow_config=args.replace_workflow_config,
                     ),
                     storage_settings=storage_settings,
                     storage_provider_settings=storage_provider_settings,
diff --git a/snakemake/settings/types.py b/snakemake/settings/types.py
@@ -348,7 +348,7 @@ class ConfigSettings(SettingsBase):
     config: Mapping[str, str] = immutables.Map()
     configfiles: Sequence[Path] = tuple()
     config_args: Optional[str] = None
-    replace_workflow: bool = False
+    replace_workflow_config: bool = False
 
     def __post_init__(self):
         self.overwrite_config = self._get_overwrite_config()
@@ -364,11 +364,6 @@ def _get_overwrite_config(self):
                 update_config(overwrite_config, load_configfile(f))
         if self.config:
             update_config(overwrite_config, self.config)
-        if self.replace_workflow and not overwrite_config:
-            logger.warning(
-                "--replace-workflow-config was used but no config entries are provided via "
-                "command line. This flag will be ignored."
-            )
         return overwrite_config
 
     def _get_configfiles(self):
diff --git a/snakemake/workflow.py b/snakemake/workflow.py
@@ -1548,7 +1548,7 @@ def configfile(self, fp):
                 update_config(self.config, c)
                 if self.config_settings.overwrite_config:
                     merge_action = "extended"
-                    if self.config_settings.replace_workflow:
+                    if self.config_settings.replace_workflow_config:
                         # discard entire global config before merging
                         self.globals["config"] = {}
                         merge_action = "replaced"
