fix: fix follow-up issue with group job handling when retrieving storage (#3871)

johanneskoester · web-flow · commit 20b99ac43eca · 2025-12-09T10:48:52.000+01:00
inputs

&lt;!--Add a description of your PR here--&gt;

### QC
&lt;!-- Make sure that you can tick the boxes below. --&gt;

* [x] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
* [x] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).


&lt;!-- This is an auto-generated comment: release notes by coderabbit.ai
--&gt;

## Summary by CodeRabbit

* **Bug Fixes**
* Refined job input evaluation logic for improved handling of external
inputs and job status checking.

&lt;sub&gt;✏️ Tip: You can customize this high-level summary in your review
settings.&lt;/sub&gt;

&lt;!-- end of auto-generated comment: release notes by coderabbit.ai --&gt;
diff --git a/src/snakemake/dag.py b/src/snakemake/dag.py
@@ -421,13 +421,13 @@ def access_pattern(f):
                 for f in inner_job.input:
                     if (
                         f.is_storage
-                        and not job.is_norun
+                        and not inner_job.is_norun
                         and (
                             # if f exists in storage, retrieve below will check if it is
                             # newer than an eventual local copy
                             (also_missing_internal and await f.exists_in_storage())
                             or self.is_external_input(
-                                f, job, not_needrun_is_external=True
+                                f, inner_job, not_needrun_is_external=True
                             )
                         )
                     ):
