Skip to content

Set up continuous integration workflow#32

Merged
mbhall88 merged 4 commits intosnakemake:masterfrom
mbhall88:master
Apr 21, 2020
Merged

Set up continuous integration workflow#32
mbhall88 merged 4 commits intosnakemake:masterfrom
mbhall88:master

Conversation

@mbhall88
Copy link
Copy Markdown
Member

This PR closes #16

It adds GitHub Actions continuous integration for

  • Linting - via flake8
  • Formatting - via black
  • Testing - via pytest
  • Code coverage report - via codecov

@mbhall88 mbhall88 requested a review from bricoletc April 20, 2020 19:08
@mbhall88 mbhall88 removed the request for review from johanneskoester April 20, 2020 19:08
@bricoletc
Copy link
Copy Markdown
Collaborator

Looking good

I'm fairly unfamiliar with all this. Will CI fail if coverage goes down? Actually how is coverage affecting the CI?
And we should update contributing.md adding at least flake8 i guess?

@mbhall88
Copy link
Copy Markdown
Member Author

Good point. I have updated the pre-commit hooks to add flake8 and also mentioned in CONTRIBUTING.md.
CI won't fail if coverage goes down. It will provide a comment on a PR though and say whether coverage has decreased/increased/stayed the same (e.g. mbhall88#1 (comment)). It will fail the CI if it fails to detect/upload the coverage report though.

Copy link
Copy Markdown
Collaborator

@bricoletc bricoletc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@mbhall88 mbhall88 merged commit 70a7d4c into snakemake:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up CI

2 participants