Correctly parse multiple input parameters for functions

thk123 · thk123 · commit 2a5c280f7fa1 · 2017-10-26T10:24:06.000+01:00
When there is a function on a generic type whose params are inner
classes we would wrongly parse only up to the inner class dot for the
name. This resulted in wrong parameters causing us to fall back on the
descriptor unnecessarily.

Instead we should find the semi-colon that matches the L for each
parameter before moving on to the next parameter.
diff --git a/src/java_bytecode/java_types.cpp b/src/java_bytecode/java_types.cpp
@@ -437,14 +437,7 @@ typet java_type_from_string(
           // parameter is an object type or instantiated generic type
           if(src[i]=='L')
           {
-            size_t generic_open=src.find('<', i);
-            size_t end_pos=src.find(';', i);
-            // generic signature
-            if(generic_open!=std::string::npos && generic_open<end_pos)
-              // point to ';' immediately after the closing '>'
-              i=find_closing_delimiter(src, generic_open, '<', '>')+1;
-            else
-              i=src.find(';', i); // ends on ;
+            i = find_closing_semi_colon_for_reference_type(src, i);
             break;
           }
 
