Skip to content

Conversation

@denislavstanchev
Copy link
Contributor

@denislavstanchev denislavstanchev commented Oct 7, 2025

Pull Request

Summary

Add the new provisionalExpirationDate field in the Users model

Checklist

  • Read the contribution guide
  • Successfully build your changes locally - Run ./gradlew clean build
  • Include a title that clearly describes your changes and references relevant issues / backlog items
  • Include a summary of your changes
  • Include tests for your changes where possible

@ggyurchev ggyurchev self-requested a review October 7, 2025 11:41
ggoranov-smar
ggoranov-smar previously approved these changes Oct 8, 2025
Copy link
Contributor

@velihanzelev-smartsheet velihanzelev-smartsheet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, we need a test proving that this DATETIME field can be parsed successfully, we are fed up with Java DateTime de/serializer hidden and visible problems

@ggoranov-smar ggoranov-smar merged commit cbe751f into smartsheet:mainline Oct 23, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants