Merge pull request #819 from dellekappa/fix/aks-client-secret

hslatman · web-flow · commit 2f6e4315c332 · 2025-08-05T16:04:32.000+02:00
Fix usage of azure keyvault client-secret when specified in URI
diff --git a/kms/azurekms/key_vault.go b/kms/azurekms/key_vault.go
@@ -191,7 +191,7 @@ var createCredentials = func(_ context.Context, opts apiv1.Options) (azcore.Toke
 		//   - client-secret
 		//   - tenant-id
 		if clientID != "" && clientSecret != "" && tenantID != "" {
-			return azidentity.NewClientSecretCredential(tenantID, clientID, clientID, &azidentity.ClientSecretCredentialOptions{
+			return azidentity.NewClientSecretCredential(tenantID, clientID, clientSecret, &azidentity.ClientSecretCredentialOptions{
 				ClientOptions: clientOptions,
 			})
 		}

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ var createCredentials = func(_ context.Context, opts apiv1.Options) (azcore.Toke`
`191`	`191`	`// - client-secret`
`192`	`192`	`// - tenant-id`
`193`	`193`	`if clientID != "" && clientSecret != "" && tenantID != "" {`
`194`		`- return azidentity.NewClientSecretCredential(tenantID, clientID, clientID, &azidentity.ClientSecretCredentialOptions{`
	`194`	`+ return azidentity.NewClientSecretCredential(tenantID, clientID, clientSecret, &azidentity.ClientSecretCredentialOptions{`
`195`	`195`	`ClientOptions: clientOptions,`
`196`	`196`	`})`
`197`	`197`	`}`