DYN-3241: Deploy md2html.exe as a single.exe#1
DYN-3241: Deploy md2html.exe as a single.exe#1sm6srw merged 8 commits intomore_failing_test_fixesfrom
Conversation
sm6srw
changed the title
src/Tools/Md2Html/Md2Html.csproj
Outdated
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | ||
| <Target Name="AfterBuild"> | ||
| <!-- the ILMergePath property points to the location of ILMerge.exe console application --> | ||
| <Exec Command="$(ILMergeConsolePath) $(OutputPath)Md2Html.exe ^ |
There was a problem hiding this comment.
where does this live though? In the packages folder?
| <Optimize>true</Optimize> | ||
| <OutputPath>$(OutputPath)\Md2Html\</OutputPath> | ||
| <SharedOutputPath>$(OutputPath)\Md2Html\</SharedOutputPath> | ||
| <OutputPath>bin\AnyCPU\Release\</OutputPath> |
There was a problem hiding this comment.
can you explain this and why it needs two output paths and hardcoded path?
There was a problem hiding this comment.
SharedOutputPath points to a md2Html directory in our shared bin folder.
OutputPath points to a local output folder relative to the project file.
ILMerge is then used for building a single .exe that is placed in the shared folder from the files in the local bin folder.
|
@sm6srw did you try |
|
Yes, that might work, assuming nobody uses mono on windows? I will take a look. |
|
@sm6srw it looks good either way - but maybe one improvement would be to add a local readme file to this folder describing the build steps and super briefly what the tool does? |
This reverts commit 9904525.
|
@mjkkirschner Reusing the same csproj file now. I will add a README for the tool as a separate task. |
|
Added Readme. I will merge this PR now. |
2 participants
Purpose
Deploy md2html.exe as a single.exe
This Pull Request does:
Note: I did not find a good way to use the same project file for both windows and mono. Let me know if you know about a way to detect mono inside a csproj file.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs