Skip to content

Option to configure rekor server.#391

Merged
laurentsimon merged 3 commits intoslsa-framework:mainfrom
naveensrinivasan:naveen/feat/configure-rekor
Jun 27, 2022
Merged

Option to configure rekor server.#391
laurentsimon merged 3 commits intoslsa-framework:mainfrom
naveensrinivasan:naveen/feat/configure-rekor

Conversation

@naveensrinivasan
Copy link
Copy Markdown
Contributor

Signed-off-by: naveensrinivasan [email protected]

- Provided an option to configure the rekor server.
- Fixes slsa-framework#372

Signed-off-by: naveensrinivasan <[email protected]>
Copy link
Copy Markdown
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread internal/builders/go/main.go Outdated
Comment thread internal/builders/go/main.go Outdated
@ianlewis
Copy link
Copy Markdown
Member

I think we might want to update the generic generator as well before closing #372 though.

@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/configure-rekor branch 2 times, most recently from c177021 to 413cdfe Compare June 24, 2022 15:12
Comment thread internal/builders/go/main.go Outdated
@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/configure-rekor branch from 413cdfe to 3c0b783 Compare June 24, 2022 16:17
@laurentsimon laurentsimon enabled auto-merge (squash) June 27, 2022 23:08
Copy link
Copy Markdown
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@laurentsimon laurentsimon merged commit c206bf3 into slsa-framework:main Jun 27, 2022
laurentsimon added a commit to laurentsimon/slsa-github-generator that referenced this pull request Jun 29, 2022
* Option to configure rekor server.

- Provided an option to configure the rekor server.
- Fixes slsa-framework#372

Signed-off-by: naveensrinivasan <[email protected]>

* mend

Co-authored-by: laurentsimon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Support a configurable Rekor URL

3 participants