Repository navigation
Commit b0e204a
committed
fix(pipeline): at 缺失时兜底键改用内容指纹,同一 run 重复出现不再报两次
#507 评审两点,逐条落实:
1. 兜底键从位置索引改为 run 自身内容(by + triggeredBy + 按序 step id)。
评审指出 violationSeen 跨整本账本共享,而索引只在「本次遍历的数组顺序」
里唯一——同一条 run 在账本里出现两次时,索引会让它的同一条违规被记成
两条,正是本条要修的那类「键塌缩」的反面形态。
评审希望的中间层 run.id 在这里不存在:normalizeRun
(src/pipeline-runs.js:187)只产出 { at, by, triggeredBy, steps },而
suggestRetirements 收到的已经是归一化后的 run;补 id 要改写侧契约,
不属这条防御深度问题。内容指纹是同一意图下不动 schema 的等价物。
2. 两类键加不同前缀(at: / anon:)。否则「第 0 条缺 at」与「另一条 at
字面量正好是 #0」会生成同一个键,后一条 violation-precedence 被静默
吞掉(CodeRabbit 同一处也点了这个碰撞)。
测试:补「同一条 run 出现两次只报一次」与「at 字面量与兜底键不相撞」两条,
均已验红→绿(换回索引兜底,这两条转红)。原「两条无 at 的 run 不塌缩」一条
改为用内容不同的两条 run——内容相同的两条在无 id 的前提下不可区分,那是
schema 的事实,不是实现的取舍。
Refs #5071 parent f7dacac commit b0e204a
3 files changed
Lines changed: 75 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
121 | 140 | | |
122 | 141 | | |
123 | 142 | | |
124 | 143 | | |
125 | 144 | | |
126 | 145 | | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
| 146 | + | |
135 | 147 | | |
136 | 148 | | |
137 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
121 | 140 | | |
122 | 141 | | |
123 | 142 | | |
124 | 143 | | |
125 | 144 | | |
126 | 145 | | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
| 146 | + | |
135 | 147 | | |
136 | 148 | | |
137 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
156 | 155 | | |
157 | 156 | | |
158 | 157 | | |
159 | 158 | | |
160 | | - | |
| 159 | + | |
161 | 160 | | |
162 | 161 | | |
163 | | - | |
| 162 | + | |
164 | 163 | | |
165 | 164 | | |
166 | 165 | | |
167 | 166 | | |
168 | 167 | | |
169 | 168 | | |
170 | 169 | | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
171 | 198 | | |
172 | 199 | | |
173 | 200 | | |
| |||
0 commit comments