Repository navigation
Commit a27c4ef
committed
fix(pipeline): 匿名指纹补 step.at 等结构化字段,漏掉会合并两条不同 run 的违规
#507 合并后 CodeRabbit 复盘时发现首版判据仍有一处漏:匿名指纹只取了 step 的
id,没取 at。两条都缺 run.at、其余全同、只在 steps[0].at 上不同的 run 会共键,
后一条 violation-precedence 被去重吞掉——正是 #461 要修的那类「键塌缩」的
反面形态(该分开的被并了)。
同时**不能**把整个 step 对象序列化进去:note 是自由文本,进去会让「只差备注的
同一条观测」被当成两次。归一化 step(src/pipeline-runs.js:242 normalizeSteps)
的字段是 { id, at, skipped, detoured, refuted, note },收前五个、不收 note。
三个结局布尔也收,尽管它们对去重正确性是**惰性**的(violation 判定只读
doneIds 与 id 是否存在,refuted 根本不被读)——全收是为了让规则统一(指纹 =
归一化 step 的每个结构化字段,唯一例外是自由文本),且将来 violation 逻辑若
开始读某个旗标时不会突然开始漏合并。代价如实记在注释与测试里:两条只差惰性
旗标的 at-less run 会各报一条逐字相同的提议。
编码用 JSON.stringify 而不是手写 `${id}@${at}` 拼接:run 侧 step id 只过
isSafeSegment(src/pipeline-runs.js:83),`@` `,` `:` 都是合法 id,手写拼接会
把 [{A,t1},{B,t1},{C,t1}] 与 [{"A@t1,B",t1},{C,t1}] 撞成同一个键——那会新造
一类键塌缩。JSON 自带无歧义分隔。
生产不可达性没有变:readStoredRun(src/pipeline-runs.js:262)强制 run.at 存在,
正常账本永远走 `at:` 分支。这里纯属 suggestRetirements 直接调用边界的防御深度,
#461 自己也是这样定位的(现网风险:低)。
测试:新增四条,均已验红→green(把指纹退回只取 step.id,两条转红):
- 只差 steps[0].at 的两条 at-less run 各报一条
- 只差 steps[0].note 的两条 at-less run 仍是同一条(前瞻守卫,今天修复前后
都是 1,但把 note 塞进指纹就会转红)
- 只差 refuted 的两条 at-less run 给出两条逐字相同的提议(锁旗标语义与代价)
- step id 含 @/, 不撞键(锁 JSON.stringify 编码,退回手写拼接会漏报)
本地全量 2311 passed / 0 failed,lib 与 src 一致。
Refs #5071 parent bac97a9 commit a27c4ef
3 files changed
Lines changed: 156 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
| 125 | + | |
| 126 | + | |
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
| |||
136 | 137 | | |
137 | 138 | | |
138 | 139 | | |
139 | | - | |
| 140 | + | |
140 | 141 | | |
141 | 142 | | |
142 | 143 | | |
| |||
260 | 261 | | |
261 | 262 | | |
262 | 263 | | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
263 | 305 | | |
264 | 306 | | |
265 | 307 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
| 125 | + | |
| 126 | + | |
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
| |||
136 | 137 | | |
137 | 138 | | |
138 | 139 | | |
139 | | - | |
| 140 | + | |
140 | 141 | | |
141 | 142 | | |
142 | 143 | | |
| |||
260 | 261 | | |
261 | 262 | | |
262 | 263 | | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
263 | 305 | | |
264 | 306 | | |
265 | 307 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
0 commit comments