Skip to content

Commit 5c20372

Browse files
committed
fix(dream): 决策前缀唯一解析 + 失败路径校验明细落库 (#135)
Issue #135 报告中可立即落地的两处修复(建议 1/2): 1. validateDecisions 校验前把「唯一前缀」解析回完整 id(git 短哈希式): 仅在 snapshot 内解析,<8 位不猜、有歧义不猜、匹配不到原样保留,仍由 unknown id 校验如实报错;就地改写 ids/keepSource/winner/loser,下游 applyDecisions 与审计拿到的同样是完整 id。返回值新增 resolvedShortIds, dream 侧解析量 >0 时记 info——这是模型缩写 id 行为的直接信号。 2. invalid-decisions 失败路径:skipped 明细的 warn 提到 return 之前 (原先写在 return 之后永远不可达),并把 { _validationFailed, errors, skipped } 随 dream_runs.decisions 持久化。此前失败轮零现场(报告实测 168 轮失败没有一轮留下模型输出痕迹),事后可从审计行直接定位。 测试:+5(唯一前缀还原 ids/keepSource、conflict winner/loser 还原、 歧义前缀不猜、无匹配前缀不猜、失败落库端到端)。全量 819 项通过。 解析语义参考报告者 aizhimoran 的验证补丁(#135 认领评论已注明)。
1 parent 7c75690 commit 5c20372

5 files changed

Lines changed: 204 additions & 18 deletions

File tree

‎dsh-mneme/lib/dream.js‎

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,7 @@ export function createDreamScheduler({ onRun, thresholdCount = 10, thresholdChar
720720
logger?.warn?.(`dsh-mneme dream: no json array in llm output (raw length ${decisionText?.length ?? 0}; head: ${head})`);
721721
return finish({ ok: false, error: "no json array in llm output", summary: false });
722722
}
723-
const { ok, errors, skipped } = validateDecisions(decisions, snapshot, {
723+
const { ok, errors, skipped, resolvedShortIds } = validateDecisions(decisions, snapshot, {
724724
maxUpdatePerRun: config.reflectionUpdateMaxPerRun,
725725
minAgeHours: config.reflectionUpdateMinAgeHours,
726726
// v0.4.4 fix:显式透传,用户配 dreamImplicitKeep:false 时严格模式必须
@@ -732,9 +732,28 @@ export function createDreamScheduler({ onRun, thresholdCount = 10, thresholdChar
732732
skipInvalid: config.dreamSkipInvalid !== false,
733733
allowCrossTypeMerge: config.allowCrossTypeMerge === true
734734
});
735+
// Issue #135:模型把 UUID 缩写成前缀时,唯一前缀已在校验前被解析回完整 id。
736+
// 解析量是模型输出质量的一个直接信号(>0 意味着模型在缩写 id),记一条 info
737+
// 便于事后从日志侧观察该行为的分布。
738+
if (resolvedShortIds > 0) {
739+
logger?.info?.(`[dsh-mneme] dream: resolved ${resolvedShortIds} short id prefix(es) to full ids`);
740+
}
735741
if (!ok) {
742+
// Issue #135(观测缺口):失败轮的逐条校验明细此前既不落库也基本不可见——
743+
// skipped 的 warn 写在 return 之后(失败路径到不了),dream_runs.decisions
744+
// 落 NULL,上百轮失败零现场。这里把明细前置到日志,并把
745+
// { _validationFailed, errors, skipped } 随失败行持久化,事后可从审计行
746+
// 直接定位「模型输出了什么、为何逐条非法」。
736747
logger?.warn?.(`dsh-mneme dream: invalid decisions: ${errors.join("; ")}`);
737-
return finish({ ok: false, error: `invalid decisions: ${errors.length} errors`, summary: false });
748+
if (skipped.length > 0) {
749+
logger?.warn?.(`dsh-mneme dream: ${skipped.length} invalid decision(s) skipped: ${skipped.map((s) => `decision[${s.index}]: ${s.error}`).join("; ")}`);
750+
}
751+
return finish({
752+
ok: false,
753+
error: `invalid decisions: ${errors.length} errors`,
754+
summary: false,
755+
decisions: [{ _validationFailed: true, errors, skipped }]
756+
});
738757
}
739758
const skippedInvalid = skipped.length > 0;
740759
if (skippedInvalid) {

‎dsh-mneme/lib/dream/decisions.js‎

Lines changed: 41 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ const EPISTEMIC_PRIORITY = { observation: 3, inferred: 2, subjective: 1 };
1313
* entries are spliced out of this array in place (the caller reuses the same
1414
* reference downstream for apply/audit); implicit keeps are appended here too.
1515
* @param snapshot - Map<id, memory> of eligible (non-archived, non-summary) entries.
16-
* @returns {{ok: boolean, errors: string[], skipped?: Array<{index, action, ids, error}>}}
16+
* @returns {{ok: boolean, errors: string[], skipped?: Array<{index, action, ids, error}>,
17+
* resolvedShortIds?: number}}
1718
*/
1819
export function validateDecisions(decisions, snapshot, options = {}) {
1920
const errors = [];
@@ -28,14 +29,47 @@ export function validateDecisions(decisions, snapshot, options = {}) {
2829
const maxUpdatePerRun = options.maxUpdatePerRun ?? 2;
2930
const minAgeHours = options.minAgeHours ?? 24;
3031
if (!Array.isArray(decisions)) {
31-
return { ok: false, errors: ["decision list must be an array"] };
32+
return { ok: false, errors: ["decision list must be an array"], resolvedShortIds: 0 };
3233
}
3334
// 空决策 = 模型完整评估后确认无需操作(CONSOLIDATION_PROMPT 明确允许"无问题的
3435
// 条目无需输出")。合法 JSON [] 不是空体(那是无输出/截断),也不是"残缺输出"
3536
// ——显式短路直接 ok,避免隐式 keep 的覆盖率检查把 0% 误判为模型坏了。与
3637
// sleep 的空模式(skipped no-op)语义对齐:下游 applied=0、audit 记 ok。
3738
if (decisions.length === 0) {
38-
return { ok: true, errors: [], skipped: [] };
39+
return { ok: true, errors: [], skipped: [], resolvedShortIds: 0 };
40+
}
41+
// Issue #135:模型常把 36 位 UUID 回填成前缀(实测 78/78 个 8 位前缀都能唯一
42+
// 对应窗口内真实记忆,且 few-shot 示例的 "m1"/"m2" 占位符在诱导这种缩写),而
43+
// 下方校验用 snapshot.get(id) 整串精确匹配 → 全部 unknown id → claimed=0 →
44+
// 覆盖率闸整单拒绝,一整轮语义成果被丢。校验前先把「唯一前缀」解析回完整 id
45+
// (git 短哈希式):仅在 snapshot 内解析,有歧义或匹配不到就原样保留,仍由下
46+
// 方 unknown id 校验如实报错。就地改写 ids / keepSource / winner / loser,下
47+
// 游 applyDecisions 与审计拿到的同样是完整 id。
48+
let resolvedShortIds = 0;
49+
const resolveShortId = (value) => {
50+
if (typeof value !== "string" || snapshot.has(value)) return value;
51+
// 太短不猜(歧义概率高);长度 ≥36 说明不是前缀缩写,交给校验如实报错。
52+
if (value.length < 8 || value.length >= 36) return value;
53+
let hit = null;
54+
let matches = 0;
55+
for (const id of snapshot.keys()) {
56+
if (id.startsWith(value)) {
57+
hit = id;
58+
if (++matches > 1) return value; // 有歧义,不解析
59+
}
60+
}
61+
if (matches === 1) {
62+
resolvedShortIds++;
63+
return hit;
64+
}
65+
return value;
66+
};
67+
for (const d of decisions) {
68+
if (!d || typeof d !== "object") continue;
69+
if (Array.isArray(d.ids)) d.ids = d.ids.map(resolveShortId);
70+
if (typeof d.keepSource === "string") d.keepSource = resolveShortId(d.keepSource);
71+
if (typeof d.winner === "string") d.winner = resolveShortId(d.winner);
72+
if (typeof d.loser === "string") d.loser = resolveShortId(d.loser);
3973
}
4074
const claimed = new Set();
4175
for (const [index, d] of decisions.entries()) {
@@ -172,14 +206,14 @@ export function validateDecisions(decisions, snapshot, options = {}) {
172206
// snapshot(claimed.size / snapshot.size < dreamMinExplicitCoverage)时整单拒绝,
173207
// 而不是用 keep 把绝大部分 snapshot 全部"通过"。
174208
if (errors.length > 0) {
175-
return { ok: false, errors, skipped };
209+
return { ok: false, errors, skipped, resolvedShortIds };
176210
}
177211
const minCoverage = options.dreamMinExplicitCoverage ?? 0.5;
178212
if (options.dreamImplicitKeep !== false) {
179213
const coverage = snapshot.size > 0 ? claimed.size / snapshot.size : 1;
180214
if (coverage < minCoverage) {
181215
errors.push(`explicit decision coverage ${Math.round(coverage * 100)}% < minimum ${Math.round(minCoverage * 100)}%`);
182-
return { ok: false, errors, skipped };
216+
return { ok: false, errors, skipped, resolvedShortIds };
183217
}
184218
for (const id of snapshot.keys()) {
185219
if (!claimed.has(id)) survivors.push({ action: "keep", ids: [id] });
@@ -188,15 +222,15 @@ export function validateDecisions(decisions, snapshot, options = {}) {
188222
for (const id of snapshot.keys()) {
189223
if (!claimed.has(id)) errors.push(`memory ${JSON.stringify(id)} missing from decisions`);
190224
}
191-
if (errors.length > 0) return { ok: false, errors, skipped };
225+
if (errors.length > 0) return { ok: false, errors, skipped, resolvedShortIds };
192226
}
193227
// 调用方下游(apply/audit)复用同一 decisions 引用:就地同步为 survivors——
194228
// 在 skipInvalid 模式下去掉被跳过的非法决策;在隐式 keep 下追加补齐的 keep。
195229
// 不能以 survivors.length !== decisions.length 作为是否 splice 的判据:
196230
// 当"被跳过的非法决策数 == 隐式补齐的 keep 数"时长度回到相等但内容已变,
197231
// 被跳过的决策会残留进 apply/audit。一律无条件 splice 最安全。
198232
decisions.splice(0, decisions.length, ...survivors);
199-
return { ok: true, errors, skipped };
233+
return { ok: true, errors, skipped, resolvedShortIds };
200234
}
201235

202236
/** Marker thrown when a decision target changed since the run snapshot. */

‎dsh-mneme/src/dream.js‎

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,7 @@ export function createDreamScheduler({ onRun, thresholdCount = 10, thresholdChar
720720
logger?.warn?.(`dsh-mneme dream: no json array in llm output (raw length ${decisionText?.length ?? 0}; head: ${head})`);
721721
return finish({ ok: false, error: "no json array in llm output", summary: false });
722722
}
723-
const { ok, errors, skipped } = validateDecisions(decisions, snapshot, {
723+
const { ok, errors, skipped, resolvedShortIds } = validateDecisions(decisions, snapshot, {
724724
maxUpdatePerRun: config.reflectionUpdateMaxPerRun,
725725
minAgeHours: config.reflectionUpdateMinAgeHours,
726726
// v0.4.4 fix:显式透传,用户配 dreamImplicitKeep:false 时严格模式必须
@@ -732,9 +732,28 @@ export function createDreamScheduler({ onRun, thresholdCount = 10, thresholdChar
732732
skipInvalid: config.dreamSkipInvalid !== false,
733733
allowCrossTypeMerge: config.allowCrossTypeMerge === true
734734
});
735+
// Issue #135:模型把 UUID 缩写成前缀时,唯一前缀已在校验前被解析回完整 id。
736+
// 解析量是模型输出质量的一个直接信号(>0 意味着模型在缩写 id),记一条 info
737+
// 便于事后从日志侧观察该行为的分布。
738+
if (resolvedShortIds > 0) {
739+
logger?.info?.(`[dsh-mneme] dream: resolved ${resolvedShortIds} short id prefix(es) to full ids`);
740+
}
735741
if (!ok) {
742+
// Issue #135(观测缺口):失败轮的逐条校验明细此前既不落库也基本不可见——
743+
// skipped 的 warn 写在 return 之后(失败路径到不了),dream_runs.decisions
744+
// 落 NULL,上百轮失败零现场。这里把明细前置到日志,并把
745+
// { _validationFailed, errors, skipped } 随失败行持久化,事后可从审计行
746+
// 直接定位「模型输出了什么、为何逐条非法」。
736747
logger?.warn?.(`dsh-mneme dream: invalid decisions: ${errors.join("; ")}`);
737-
return finish({ ok: false, error: `invalid decisions: ${errors.length} errors`, summary: false });
748+
if (skipped.length > 0) {
749+
logger?.warn?.(`dsh-mneme dream: ${skipped.length} invalid decision(s) skipped: ${skipped.map((s) => `decision[${s.index}]: ${s.error}`).join("; ")}`);
750+
}
751+
return finish({
752+
ok: false,
753+
error: `invalid decisions: ${errors.length} errors`,
754+
summary: false,
755+
decisions: [{ _validationFailed: true, errors, skipped }]
756+
});
738757
}
739758
const skippedInvalid = skipped.length > 0;
740759
if (skippedInvalid) {

‎dsh-mneme/src/dream/decisions.js‎

Lines changed: 41 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ const EPISTEMIC_PRIORITY = { observation: 3, inferred: 2, subjective: 1 };
1313
* entries are spliced out of this array in place (the caller reuses the same
1414
* reference downstream for apply/audit); implicit keeps are appended here too.
1515
* @param snapshot - Map<id, memory> of eligible (non-archived, non-summary) entries.
16-
* @returns {{ok: boolean, errors: string[], skipped?: Array<{index, action, ids, error}>}}
16+
* @returns {{ok: boolean, errors: string[], skipped?: Array<{index, action, ids, error}>,
17+
* resolvedShortIds?: number}}
1718
*/
1819
export function validateDecisions(decisions, snapshot, options = {}) {
1920
const errors = [];
@@ -28,14 +29,47 @@ export function validateDecisions(decisions, snapshot, options = {}) {
2829
const maxUpdatePerRun = options.maxUpdatePerRun ?? 2;
2930
const minAgeHours = options.minAgeHours ?? 24;
3031
if (!Array.isArray(decisions)) {
31-
return { ok: false, errors: ["decision list must be an array"] };
32+
return { ok: false, errors: ["decision list must be an array"], resolvedShortIds: 0 };
3233
}
3334
// 空决策 = 模型完整评估后确认无需操作(CONSOLIDATION_PROMPT 明确允许"无问题的
3435
// 条目无需输出")。合法 JSON [] 不是空体(那是无输出/截断),也不是"残缺输出"
3536
// ——显式短路直接 ok,避免隐式 keep 的覆盖率检查把 0% 误判为模型坏了。与
3637
// sleep 的空模式(skipped no-op)语义对齐:下游 applied=0、audit 记 ok。
3738
if (decisions.length === 0) {
38-
return { ok: true, errors: [], skipped: [] };
39+
return { ok: true, errors: [], skipped: [], resolvedShortIds: 0 };
40+
}
41+
// Issue #135:模型常把 36 位 UUID 回填成前缀(实测 78/78 个 8 位前缀都能唯一
42+
// 对应窗口内真实记忆,且 few-shot 示例的 "m1"/"m2" 占位符在诱导这种缩写),而
43+
// 下方校验用 snapshot.get(id) 整串精确匹配 → 全部 unknown id → claimed=0 →
44+
// 覆盖率闸整单拒绝,一整轮语义成果被丢。校验前先把「唯一前缀」解析回完整 id
45+
// (git 短哈希式):仅在 snapshot 内解析,有歧义或匹配不到就原样保留,仍由下
46+
// 方 unknown id 校验如实报错。就地改写 ids / keepSource / winner / loser,下
47+
// 游 applyDecisions 与审计拿到的同样是完整 id。
48+
let resolvedShortIds = 0;
49+
const resolveShortId = (value) => {
50+
if (typeof value !== "string" || snapshot.has(value)) return value;
51+
// 太短不猜(歧义概率高);长度 ≥36 说明不是前缀缩写,交给校验如实报错。
52+
if (value.length < 8 || value.length >= 36) return value;
53+
let hit = null;
54+
let matches = 0;
55+
for (const id of snapshot.keys()) {
56+
if (id.startsWith(value)) {
57+
hit = id;
58+
if (++matches > 1) return value; // 有歧义,不解析
59+
}
60+
}
61+
if (matches === 1) {
62+
resolvedShortIds++;
63+
return hit;
64+
}
65+
return value;
66+
};
67+
for (const d of decisions) {
68+
if (!d || typeof d !== "object") continue;
69+
if (Array.isArray(d.ids)) d.ids = d.ids.map(resolveShortId);
70+
if (typeof d.keepSource === "string") d.keepSource = resolveShortId(d.keepSource);
71+
if (typeof d.winner === "string") d.winner = resolveShortId(d.winner);
72+
if (typeof d.loser === "string") d.loser = resolveShortId(d.loser);
3973
}
4074
const claimed = new Set();
4175
for (const [index, d] of decisions.entries()) {
@@ -172,14 +206,14 @@ export function validateDecisions(decisions, snapshot, options = {}) {
172206
// snapshot(claimed.size / snapshot.size < dreamMinExplicitCoverage)时整单拒绝,
173207
// 而不是用 keep 把绝大部分 snapshot 全部"通过"。
174208
if (errors.length > 0) {
175-
return { ok: false, errors, skipped };
209+
return { ok: false, errors, skipped, resolvedShortIds };
176210
}
177211
const minCoverage = options.dreamMinExplicitCoverage ?? 0.5;
178212
if (options.dreamImplicitKeep !== false) {
179213
const coverage = snapshot.size > 0 ? claimed.size / snapshot.size : 1;
180214
if (coverage < minCoverage) {
181215
errors.push(`explicit decision coverage ${Math.round(coverage * 100)}% < minimum ${Math.round(minCoverage * 100)}%`);
182-
return { ok: false, errors, skipped };
216+
return { ok: false, errors, skipped, resolvedShortIds };
183217
}
184218
for (const id of snapshot.keys()) {
185219
if (!claimed.has(id)) survivors.push({ action: "keep", ids: [id] });
@@ -188,15 +222,15 @@ export function validateDecisions(decisions, snapshot, options = {}) {
188222
for (const id of snapshot.keys()) {
189223
if (!claimed.has(id)) errors.push(`memory ${JSON.stringify(id)} missing from decisions`);
190224
}
191-
if (errors.length > 0) return { ok: false, errors, skipped };
225+
if (errors.length > 0) return { ok: false, errors, skipped, resolvedShortIds };
192226
}
193227
// 调用方下游(apply/audit)复用同一 decisions 引用:就地同步为 survivors——
194228
// 在 skipInvalid 模式下去掉被跳过的非法决策;在隐式 keep 下追加补齐的 keep。
195229
// 不能以 survivors.length !== decisions.length 作为是否 splice 的判据:
196230
// 当"被跳过的非法决策数 == 隐式补齐的 keep 数"时长度回到相等但内容已变,
197231
// 被跳过的决策会残留进 apply/audit。一律无条件 splice 最安全。
198232
decisions.splice(0, decisions.length, ...survivors);
199-
return { ok: true, errors, skipped };
233+
return { ok: true, errors, skipped, resolvedShortIds };
200234
}
201235

202236
/** Marker thrown when a decision target changed since the run snapshot. */

0 commit comments

Comments
 (0)