Repository navigation
Commit 57e7bab
committed
fix(panel): 忙碌上报改成同步,刷新不再搭关闭定时器,挂弹层的菜单项一并禁用(#386 第三轮评审)
CodeRabbit 第三轮三条,逐条核过都成立:
- 忙碌状态只靠 useEffect 上报,而 effect 要等这次渲染提交后才跑。中间那一拍
父组件的 bootstrapBusy 还是 false,此时点「⋯」照样把弹层卸掉,请求的成功或
失败就再没有地方显示。改成 setBusy(true) 之后同步调 onBusyChange(true)。
- onImported() 排在 900ms 关闭定时器里。切视图会卸载弹层并把 timerRef 清掉,
刷新随之取消——库已经写进去了,列表却还是旧的,而这条路径上用户刚看到
「新建 N 条」,最容易立刻去翻列表。改成同步刷新,只把 onClose 留在定时器。
- 会挂弹层的那五个菜单项在引导请求在飞时仍可点。这些弹层共用同一个绝对定位
锚点,后渲染的会盖住引导弹层那句「新建几条、并入几条」。一律 disabled:
bootstrapBusy;两个导出项不挂弹层,照旧可点。
测试侧:把 BootstrapDialog 的切片从「拍脑袋的 3200 字」改成切到下一个弹层的
注释为止——这轮改动静悄悄把窗口撑破,断言于是在一个截断的片段上做,失败信息
还指着「输入框没禁用」这种不存在的毛病。另补三条锁:忙碌必须同步上报、刷新
必须早于关闭定时器、五个菜单项恰好五处 disabled 且导出项一处都没有。
变异自证四条全 KILLED:去掉 share 项的 disabled、去掉同步上报、把 onImported
挪进定时器、把导出项也一起禁用(最后一条是反向断言,应当被抓住)。1 parent d95edd6 commit 57e7bab
3 files changed
Lines changed: 61 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | | - | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7163 | 7163 | | |
7164 | 7164 | | |
7165 | 7165 | | |
| 7166 | + | |
| 7167 | + | |
| 7168 | + | |
| 7169 | + | |
7166 | 7170 | | |
7167 | 7171 | | |
7168 | 7172 | | |
| |||
7185 | 7189 | | |
7186 | 7190 | | |
7187 | 7191 | | |
7188 | | - | |
| 7192 | + | |
| 7193 | + | |
| 7194 | + | |
| 7195 | + | |
| 7196 | + | |
7189 | 7197 | | |
7190 | 7198 | | |
7191 | 7199 | | |
| |||
8068 | 8076 | | |
8069 | 8077 | | |
8070 | 8078 | | |
8071 | | - | |
| 8079 | + | |
| 8080 | + | |
| 8081 | + | |
| 8082 | + | |
8072 | 8083 | | |
8073 | 8084 | | |
8074 | 8085 | | |
8075 | 8086 | | |
8076 | 8087 | | |
8077 | | - | |
| 8088 | + | |
8078 | 8089 | | |
8079 | | - | |
| 8090 | + | |
8080 | 8091 | | |
8081 | | - | |
| 8092 | + | |
8082 | 8093 | | |
8083 | | - | |
| 8094 | + | |
8084 | 8095 | | |
8085 | 8096 | | |
8086 | 8097 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1413 | 1413 | | |
1414 | 1414 | | |
1415 | 1415 | | |
1416 | | - | |
| 1416 | + | |
1417 | 1417 | | |
1418 | 1418 | | |
1419 | 1419 | | |
| |||
2741 | 2741 | | |
2742 | 2742 | | |
2743 | 2743 | | |
| 2744 | + | |
| 2745 | + | |
| 2746 | + | |
| 2747 | + | |
| 2748 | + | |
| 2749 | + | |
| 2750 | + | |
| 2751 | + | |
| 2752 | + | |
| 2753 | + | |
| 2754 | + | |
| 2755 | + | |
| 2756 | + | |
| 2757 | + | |
| 2758 | + | |
| 2759 | + | |
| 2760 | + | |
2744 | 2761 | | |
2745 | | - | |
| 2762 | + | |
| 2763 | + | |
| 2764 | + | |
| 2765 | + | |
2746 | 2766 | | |
| 2767 | + | |
| 2768 | + | |
| 2769 | + | |
| 2770 | + | |
| 2771 | + | |
| 2772 | + | |
| 2773 | + | |
2747 | 2774 | | |
2748 | 2775 | | |
2749 | 2776 | | |
| |||
2768 | 2795 | | |
2769 | 2796 | | |
2770 | 2797 | | |
| 2798 | + | |
| 2799 | + | |
| 2800 | + | |
| 2801 | + | |
| 2802 | + | |
| 2803 | + | |
| 2804 | + | |
| 2805 | + | |
| 2806 | + | |
| 2807 | + | |
| 2808 | + | |
| 2809 | + | |
| 2810 | + | |
2771 | 2811 | | |
2772 | 2812 | | |
2773 | 2813 | | |
| |||
0 commit comments