Skip to content

Commit 3a52d5f

Browse files
authored
Merge pull request #457 from slow-stack/fix/persona-delete-visibility
fix(persona): 卡删除 × 常显——修复复用 mneme-set-del 导致的永远不可见
2 parents 6ff3538 + ada14a4 commit 3a52d5f

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

‎dsh-mneme/lib/client.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3854,9 +3854,14 @@ window.__ModuleLoader__.load({
38543854
className: "mneme-btn" + (personaEditing === id ? " mneme-btn--active" : ""),
38553855
onClick: () => setPersonaEditing(id)
38563856
}, id),
3857+
// 卡删除 × 常显:不能复用 mneme-set-del(opacity:0 只在
3858+
// .mneme-set-row:hover 下显现,卡标签不在该容器里 → 永远透明,
3859+
// 用户找不到删除入口,v1.2 实测踩中)。这里给内联 opacity:1,
3860+
// 仅沿用其颜色/字号/点击区,悬停变色仍走 mneme-set-del:hover。
38573861
h("button", {
38583862
type: "button",
38593863
className: "mneme-set-del",
3864+
style: { opacity: 1, fontSize: 16, lineHeight: "18px", padding: "0 3px" },
38603865
title: t("memory.settings.personaDeleteCard"),
38613866
"aria-label": t("memory.settings.personaDeleteCard") + " " + id,
38623867
onClick: () => removePersonaCard(id)

‎dsh-mneme/test/client.test.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2054,4 +2054,11 @@ test("persona card is multi-card with visible field labels and save-failure erro
20542054
assert.ok(labelBlock, "persona field labels must be visible (featnumlabel class), not aria-only");
20552055
// 保存失败提示:personaError 状态有渲染路径(非仅 setState)
20562056
assert.ok(clientSource.includes("t(\"memory.settings.personaSaveFailed\")"), "save failure must render an error line");
2057+
// 卡删除 × 常显回归锁(v1.2 实测踩中):mneme-set-del 的 opacity:0 规则只在
2058+
// .mneme-set-row:hover 下解除,卡标签不在该容器 → 复用该类而不覆写透明度会让
2059+
// 删除按钮永远不可见。锁住卡列表的 × 必须带内联 opacity:1。
2060+
assert.ok(
2061+
/mneme-set-del",\s*\n\s*style: \{ opacity: 1[^}]*\}/.test(clientSource),
2062+
"persona card delete × must override mneme-set-del opacity (always visible)"
2063+
);
20572064
});

0 commit comments

Comments
 (0)