Skip to content

build: include golangci-lint as project tool#502

Merged
zimeg merged 3 commits intomainfrom
zimeg-build-lint-tool
Apr 20, 2026
Merged

build: include golangci-lint as project tool#502
zimeg merged 3 commits intomainfrom
zimeg-build-lint-tool

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Apr 17, 2026

Changelog

N/A - development updates!

Summary

This PR adds the golangci-lint tool to the project tools for confidence in versioning in CI and onboarding to the project 📠

Preview

- golangci-lint run
+ go tool golangci-lint run
0 issues.

Testing

Reviewers might uninstall golangci-lint and checkout this branch before build:

$ go mod tidy
$ make build

Notes

Requirements

@zimeg zimeg added this to the Next Release milestone Apr 17, 2026
@zimeg zimeg self-assigned this Apr 17, 2026
@zimeg zimeg requested a review from a team as a code owner April 17, 2026 18:53
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Apr 17, 2026
zimeg
zimeg commented Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ A comment for the kind readers!

Comment thread go.mod
gopkg.in/yaml.v3 v3.0.1 // indirect
)

tool github.com/golangci/golangci-lint/v2/cmd/golangci-lint
Copy link
Copy Markdown
Member Author

@zimeg zimeg Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧰 note: The dependencies added above are numerous but indirect toward this package and won't add to our bundle size!

Copy link
Copy Markdown
Member

@mwbrooks mwbrooks Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small price to pay for a pinned golangci-lint 🙇🏻

I'm curious what snyk will think of all the new indirect dependencies. 😛

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.16%. Comparing base (938696c) to head (1d42ffa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   71.17%   71.16%   -0.02%     
==========================================
  Files         222      222              
  Lines       18684    18684              
==========================================
- Hits        13299    13297       -2     
- Misses       4203     4205       +2     
  Partials     1182     1182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mwbrooks
mwbrooks approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Woo-wee! This is a great change. Thank you @zimeg 🙇🏻

🧪 Locally, I'm able to tidy and build successfully.

Comment thread go.mod
gopkg.in/yaml.v3 v3.0.1 // indirect
)

tool github.com/golangci/golangci-lint/v2/cmd/golangci-lint
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small price to pay for a pinned golangci-lint 🙇🏻

I'm curious what snyk will think of all the new indirect dependencies. 😛

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Apr 20, 2026

@mwbrooks Thanks so much for the review 🎁

I'm hoping we'll have better insights into vulnerabilities while also having confidence in the exact versions we're using with this so I'll merge now 🚢 💨

@zimeg zimeg enabled auto-merge (squash) April 20, 2026 18:13
@zimeg zimeg merged commit 5ffec6b into main Apr 20, 2026
8 checks passed
@zimeg zimeg deleted the zimeg-build-lint-tool branch April 20, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

Assignees

@zimeg zimeg

Labels

build M-T: Changes to compilation and CI processes code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

2 participants

@zimeg @mwbrooks