chore!: remove workspace and team aliases from the app command#463
chore!: remove workspace and team aliases from the app command#463
workspace and team aliases from the app command#463Conversation
zimeg
added
code health
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
👾 A thought of scope creep in an otherwise focused PR-
| func NewCommand(clients *shared.ClientFactory) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "app", | ||
| Aliases: []string{"workspace", "app", "apps", "team", "teams", "workspaces"}, |
There was a problem hiding this comment.
👾 note: It was unclear if the "team" aliases are right to remove but I think it makes sense to remove these with this change!
There was a problem hiding this comment.
Long history but it kinda shows the evolution of this command from being designed for "workspaces" before supporting Enterprises with a generic "teams" before realizing that we need a way to manage the specific app and not just the team that the app is installed to with "apps".
In hindsight, the CLI has no use-case today to do CRUD operations on a Workspace or Enterprise Org. That's the admin world, which we haven't feature requests around.
I'm glad to see these aliases gone though, because they're so old that they've lost their meaning.
There was a problem hiding this comment.
@mwbrooks Thank you for sharing this! That's a most interesting start and use case considered 📚
Now when I think about team or workspace the credentials I have saved is what I'd want to find. We have the command for showing an overview I prefer as:
$ slack auth listWhich can also be nice for collecting a service token:
$ slack auth tokenThanks also for confirming these aliases are alright for error at this time 🌚
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 71.01% 71.04% +0.03%
==========================================
Files 220 220
Lines 18531 18520 -11
==========================================
- Hits 13159 13157 -2
+ Misses 4192 4182 -10
- Partials 1180 1181 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| func NewCommand(clients *shared.ClientFactory) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "app", | ||
| Aliases: []string{"workspace", "app", "apps", "team", "teams", "workspaces"}, |
There was a problem hiding this comment.
Long history but it kinda shows the evolution of this command from being designed for "workspaces" before supporting Enterprises with a generic "teams" before realizing that we need a way to manage the specific app and not just the team that the app is installed to with "apps".
In hindsight, the CLI has no use-case today to do CRUD operations on a Workspace or Enterprise Org. That's the admin world, which we haven't feature requests around.
I'm glad to see these aliases gone though, because they're so old that they've lost their meaning.
|
@mwbrooks Thanks for the review and details of the command 🙏 ✨ I'm wanting to now merge this after tests complete and have noted this toward the next milestone Next Release upcoming with the correct labels as I found - noting a |
2 participants
Changelog
Summary
🪓 This PR removes the
workspaceandteamaliases from theappcommand to keep this common focused on app installations.Requirements