Conversation
zimeg
added
bug
zimeg
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 70.32% 70.36% +0.03%
==========================================
Files 220 220
Lines 18506 18506
==========================================
+ Hits 13015 13022 +7
+ Misses 4313 4307 -6
+ Partials 1178 1177 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amarinelli
approved these changes
Mar 30, 2026
Member
amarinelli
left a comment
amarinelli
left a comment
There was a problem hiding this comment.
Tested with install script in your branch. Conflict detection unchanged, suggested commands to use an alias work well. No issues. Thanks @zimeg!
Member
Author
|
@amarinelli Super duper appreciated, please know! Let's now get this merged for upcoming release 🚀 🔮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This PR updates the Windows installation scripts to show alias recommendations after the installer is downloaded if overwrites were avoided.
Fixes an issue where flags weren't parsed in the initial request - Thanks @amarinelli for the note! 🐛 ✨
Preview
These changes appear afterward:
Reviewers
Overwrite previous installs for the session and test this branch:
Notes
📚 https://docs.slack.dev/tools/slack-cli/guides/installing-the-slack-cli-for-windows
Requirements