refactor: use strings.HasPrefix instead of regexp in ensurePrefix

mwbrooks · mwbrooks · commit 218fa43d14c0 · 2026-03-30T09:26:36.000-07:00
diff --git a/internal/version/version.go b/internal/version/version.go
@@ -16,7 +16,6 @@ package version
 
 import (
 	"os"
-	"regexp"
 	"strings"
 )
 
@@ -42,8 +41,9 @@ func getVersionFromEnv() string {
 }
 
 // ensurePrefix ensures that the version string has a "v" prefix.
+// Empty strings are returned as-is to avoid producing a bare "v".
 func ensurePrefix(v string) string {
-	if match, _ := regexp.MatchString(`^[^v]`, v); match {
+	if v != "" && !strings.HasPrefix(v, "v") {
 		return "v" + v
 	}
 	return v

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@ package version`
`16`	`16`
`17`	`17`	`import (`
`18`	`18`	`"os"`
`19`		`- "regexp"`
`20`	`19`	`"strings"`
`21`	`20`	`)`
`22`	`21`
`@@ -42,8 +41,9 @@ func getVersionFromEnv() string {`
`42`	`41`	`}`
`43`	`42`
`44`	`43`	`// ensurePrefix ensures that the version string has a "v" prefix.`
	`44`	`+// Empty strings are returned as-is to avoid producing a bare "v".`
`45`	`45`	`func ensurePrefix(v string) string {`
`46`		- if match, _ := regexp.MatchString(`^[^v]`, v); match {
	`46`	`+ if v != "" && !strings.HasPrefix(v, "v") {`
`47`	`47`	`return "v" + v`
`48`	`48`	`}`
`49`	`49`	`return v`