fix incorrect homepage for legacy wrapper#793
Merged
aoberoi merged 1 commit intoslackapi:masterfrom May 30, 2019
Merged
Conversation
|
|
shaydewael
approved these changes
May 28, 2019
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 15 15
Lines 652 652
Branches 26 26
=======================================
Hits 638 638
Misses 13 13
Partials 1 1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 15 15
Lines 652 652
Branches 26 26
=======================================
Hits 638 638
Misses 13 13
Partials 1 1
Continue to review full report at Codecov.
|
Contributor
|
thanks @felixrieseberg! we'll republish soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
👋 The link on https://www.npmjs.com/package/@slack/client is incorrect. We don't handle a final
/, which in itself is probably worth looking at, but this ensures that npm doesn't route people to a disappointing 404 🙇Requirements (place an
xin each[ ])