fix[cli-test]: update buffer type in tests#2411
Merged
WilliamBergamin merged 1 commit intomainfrom Oct 22, 2025
Merged
Conversation
WilliamBergamin
added
semver:patch
tests
WilliamBergamin
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
==========================================
- Coverage 93.01% 93.01% -0.01%
==========================================
Files 40 40
Lines 11112 11111 -1
Branches 713 713
==========================================
- Hits 10336 10335 -1
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
approved these changes
Oct 22, 2025
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM and a nice find 🔍 ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These changes update expected
child.SpawnSyncreturn type to fix types issues that it blocking CIRequirements (place an
xin each[ ])