fix(types): update context_actions jsdoc link to a single icon_button#2375
fix(types): update context_actions jsdoc link to a single icon_button#2375
Conversation
zimeg
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ai-apps #2375 +/- ##
==========================================
Coverage ? 92.78%
==========================================
Files ? 39
Lines ? 10711
Branches ? 692
==========================================
Hits ? 9938
Misses ? 761
Partials ? 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
changed the title
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looking good to me!
✏️ Personally, I think you can remove the bug label and keep this focused on the docs label.
| type: 'context_actions'; | ||
| /** | ||
| * @description An array of {@link FeedbackButtons} or {@link IconButtons} objects. | ||
| * @description An array of {@link FeedbackButtons} or {@link IconButton} block elements. Maximum number of items is 5. |
There was a problem hiding this comment.
note: That tricky pluralization!
There was a problem hiding this comment.
@mwbrooks I agree but I suppose in a collection of elements it finds sense? 👾 ✨
zimeg
removed
the
bug
|
@mwbrooks Ooh great call that this wasn't an update to application logic 🧠 I believe for now this'll align with Let's merge this for now. |
2 participants
Summary
This PR updates JSDoc reference to a single
IconButtonfor thecontext_actionsblock "elements" attribute:node-slack-sdk/packages/types/src/block-kit/block-elements.ts
Lines 210 to 217 in bd62ff4
Requirements