Skip to content

Comments

feat(types): add feedback_buttons and icon_button blocks as context_actions block elements#2370

Merged
zimeg merged 6 commits intoai-appsfrom
zimeg-feat-types-feedback-actions
Sep 19, 2025
Merged

feat(types): add feedback_buttons and icon_button blocks as context_actions block elements#2370
zimeg merged 6 commits intoai-appsfrom
zimeg-feat-types-feedback-actions

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Sep 13, 2025

Summary

This PR adds the following to @slack/types:

  • feedback_buttons block action
  • icon_button block action
  • context_actions block

Requirements

@zimeg zimeg requested a review from mwbrooks September 13, 2025 01:59
@zimeg zimeg self-assigned this Sep 13, 2025
@zimeg zimeg added semver:minor enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` labels Sep 13, 2025
@codecov
Copy link

codecov bot commented Sep 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (ai-apps@e752556). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             ai-apps    #2370   +/-   ##
==========================================
  Coverage           ?   92.78%           
==========================================
  Files              ?       39           
  Lines              ?    10711           
  Branches           ?      692           
==========================================
  Hits               ?     9938           
  Misses             ?      761           
  Partials           ?       12
Flag Coverage Δ
cli-hooks 95.23% <ø> (?)
cli-test 94.80% <ø> (?)
oauth 77.39% <ø> (?)
socket-mode 61.87% <ø> (?)
web-api 98.00% <ø> (?)
webhook 96.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg marked this pull request as ready for review September 16, 2025 20:44
mwbrooks
mwbrooks approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good and matches the spec!

packages/types/src/block-kit/block-elements.ts
Comment on lines +218 to +222
/**
* @description The icon to show.
* @example trash
*/
icon: string;
Copy link
Member

@mwbrooks mwbrooks Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Today, only trash is supported. Do we typically list the supported enum values here?

Copy link
Member Author

@zimeg zimeg Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks I was so curious about this, but wanted to start more general and with an example to guard against future changes.

So open to updating this if being strict seems better of course 👁️‍🗨️ ✨

Copy link
Member

@mwbrooks mwbrooks Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think keeping it open is better as well, because it allows devs to use the SDK while the API evolves with more values!

@zimeg
Copy link
Member Author

zimeg commented Sep 19, 2025

@mwbrooks Once again, thank you tons for the kind review! I'm wanting to merge this for tests with typescript so let's 🚢 💨

@zimeg zimeg merged commit bb6de1c into ai-apps Sep 19, 2025
57 checks passed
@zimeg zimeg deleted the zimeg-feat-types-feedback-actions branch September 19, 2025 04:10
@zimeg zimeg mentioned this pull request Nov 11, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

Assignees

@zimeg zimeg

Labels

enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` semver:minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zimeg @mwbrooks