Skip to content

build: use latest biome schema version#2363

Merged
zimeg merged 1 commit intomainfrom
zimeg-build-biome-latest-schema
Sep 10, 2025
Merged

build: use latest biome schema version#2363
zimeg merged 1 commit intomainfrom
zimeg-build-biome-latest-schema

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Sep 10, 2025

Summary

This PR prefers the latest biome schema version to avoid warnings in build scripts.

Preview

Before changes

$ npm run lint

> @slack/[email protected] lint
> npx @biomejs/biome check .

biome.json:2:14 deserialize ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ⚠ The configuration schema version does not match the CLI version 2.2.0

    1 │ {
  > 2 │   "$schema": "https://biomejs.dev/schemas/2.0.5/schema.json",
      │              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    3 │   "extends": ["../../biome.json"],
    4 │   "overrides": [

  ℹ   Expected:                     2.2.0
      Found:                        2.0.5


  ℹ Run the command biome migrate to migrate the configuration file.


Checked 430 files in 63ms. No fixes applied.
Found 1 warning.

After changes

$ npm run lint

> @slack/[email protected] lint
> npx @biomejs/biome check .

Checked 430 files in 63ms. No fixes applied.

Notes

This might encourage us to keep following the latest version of biome with a minimum version requirement?

node-slack-sdk/packages/cli-hooks/package.json

Line 58 in 893a37d

"@biomejs/biome": "^2.0.5",

Although that isn't recommended...

Due to the nature of these changes, it’s highly recommended to save the exact version in your package.json, instead of using range operators.

I'd be interested in revisiting how we include some dependencies like tsc and biome to use pinned versions later or instead of this change since unexpected updates to these would be an unfortunate reason to error?

Requirements

@zimeg zimeg self-assigned this Sep 10, 2025
@zimeg zimeg added tests M-T: Testing work only dependencies Pull requests that update a dependency file labels Sep 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.77%. Comparing base (893a37d) to head (71614c3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2363   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          39       39           
  Lines       10693    10693           
  Branches      692      692           
=======================================
  Hits         9920     9920           
  Misses        761      761           
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.80% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 97.99% <ø> (ø)
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mwbrooks
mwbrooks approved these changes Sep 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good to me, since dependabot keeps biome up-to-date. This may break on a major, but we can pin the schema if that happens.

🗳️ Generally, I lean toward pinning all dependencies to specific versions. If we don't, then we may want to at least consider a package-lock.json.

WilliamBergamin
WilliamBergamin approved these changes Sep 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change 💯

If the packages biome file extend ../../biome.json do we need to define the schema in all child files?

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Sep 10, 2025

@mwbrooks @WilliamBergamin Thanks both for the reviews! I agree this is an alright workaround for warnings but we should still investigate a more stable upgrade path...

Generally, I lean toward pinning all dependencies to specific versions.

For development dependencies I agree too! Minimum versions are nice for production dependencies to unlock the newest features in application code without causing conflicts between sub-dependencies too I believe?

If the packages biome file extend ../../biome.json do we need to define the schema in all child files?

I found my editor doesn't recognize a standalone biome.json file without the schema at the moment and might not read from "extends" either 👁️‍🗨️

For now I'll merge this but am once again curious about more stable versioning for follow up! 🎁

@zimeg zimeg merged commit 765423c into main Sep 10, 2025
57 checks passed
@zimeg zimeg deleted the zimeg-build-biome-latest-schema branch September 10, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

Assignees

@zimeg zimeg

Labels

dependencies Pull requests that update a dependency file tests M-T: Testing work only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zimeg @mwbrooks @WilliamBergamin