Conversation
…prompts count in types
zimeg
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 38 38
Lines 10607 10607
Branches 683 683
=======================================
Hits 9834 9834
Misses 761 761
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4 tasks
Member
Author
|
📝 Testing notes for the kind reviewers can use changes to the sample of slack-samples/bolt-js-assistant-template#48 and this PR: $ npm pack # Package these changes before testing the sample app
$ cd ~/path/to/bolt-js
$ npm install ../node-slack-sdk/packages/web-api
$ npm pack
$ cd
$ slack create asdf -t slack-samples/bolt-js-assistant-template -b zimeg-fix-suggested-prompts-types
$ cd asdf
$ npm run check # Attempt the type check test
$ npm install ../path/to/node-slack-sdk/packages/web-api # Install these changes
$ npm run check # Confirm the sample passes the type check🗣️ Unrelated errors might be addressed in #2296! |
Member
Author
|
@WilliamBergamin Indeed. 🚢 💨 I'll plan to release this soon and bring similar changes and an update to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the minimum bounds in types for the
assistant.threads.setSuggestedPromptsmethodpromptsproperty.Fixes issues noted in slack-samples/bolt-js-assistant-template#46 and slackapi/bolt-js#2506.
Notes
Requirements