Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 38 38
Lines 10607 10607
Branches 683 683
=======================================
Hits 9834 9834
Misses 761 761
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
📝 Testing notes for the kind reviewers can use changes to the sample of slack-samples/bolt-js-assistant-template#47 and this PR: $ npm pack # Package these changes before testing the sample app
$ cd
$ slack create asdf -t slack-samples/bolt-js-assistant-template -b zimeg-feat-markdown-block
$ cd asdf
$ npm run check # Attempt the type check test
$ npm install ../path/to/node-slack-sdk/packages/types # Install these changes
$ npm run check # Confirm the sample passes the type check |
| | ImageBlock | ||
| | ContextBlock | ||
| | ActionsBlock | ||
| | ContextBlock |
There was a problem hiding this comment.
I was not sure where else to add a new block! 😉
|
@WilliamBergamin Thanks for the fast review! I'll merge this now but will plan for a soonish release 🚢 💨 |
|
Please do release it! |
|
@pedropaccola Thanks for the bump - we'll aim to release this after #2330 lands. In this meantime I might recommend using regular JSON for the block: {
"type": "markdown",
"text": "**Lots of information here!!**",
} |
Summary
This PR adds the
markdownblock to@slack/types.Requirements