Skip to content

fix: Add "title" property to conversations.canvases.create API method arguments#2259

Merged
vegeris merged 2 commits intomainfrom
conversations-canvases-create-title-arg
Jun 5, 2025
Merged

fix: Add "title" property to conversations.canvases.create API method arguments#2259
vegeris merged 2 commits intomainfrom
conversations-canvases-create-title-arg

Conversation

@vegeris
Copy link
Copy Markdown
Contributor

@vegeris vegeris commented Jun 4, 2025

Summary

Requirements

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (994659f) to head (3de2ab7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2259   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files          38       38           
  Lines       10554    10554           
  Branches      682      682           
=======================================
  Hits         9781     9781           
  Misses        761      761           
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.76% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.82% <ø> (ø)
web-api 97.95% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vegeris vegeris requested a review from zimeg June 4, 2025 23:35
@zimeg zimeg changed the title fix: Add new property to API args fix: Add "title" property to conversations.canvases.create API method arguments Jun 4, 2025
@zimeg zimeg added semver:patch area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` labels Jun 4, 2025
@zimeg zimeg added this to the [email protected] milestone Jun 4, 2025
@zimeg zimeg linked an issue Jun 4, 2025 that may be closed by this pull request
conversations.canvases.create not compliant with API Reference #2258
Closed
7 tasks
zimeg
zimeg approved these changes Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vegeris Thanks so much for a fast fix here!

Out of my own curiosity, was this change generated from the generate-web-api-types.sh script?

It great to find matching arguments in documentation but I'm not sure if running this script later might revert these changes with what exists in this file 🤔

Comment thread packages/web-api/test/types/methods/canvas.test-d.ts Outdated
@zimeg
Copy link
Copy Markdown
Member

zimeg commented Jun 5, 2025

Edit: Ahh apologies for my curious misunderstandings! That linked file seems to have the response instead of the request arguments 😅

@vegeris @zimeg
Add comma
3de2ab7 
Co-authored-by: Eden Zimbelman <[email protected]>
@vegeris
Copy link
Copy Markdown
Contributor Author

vegeris commented Jun 5, 2025

generate-web-api-types.sh script

Yeah, good callout though 👀 It does seem like we shouldn't need to regenerate those files for a request argument update

@vegeris vegeris merged commit ce6c9f6 into main Jun 5, 2025
57 checks passed
@vegeris vegeris deleted the conversations-canvases-create-title-arg branch June 5, 2025 22:23
@zimeg zimeg mentioned this pull request Jun 19, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

No one assigned

Labels

area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` semver:patch

Projects

None yet

Milestone

[email protected]

Development

Successfully merging this pull request may close these issues.

conversations.canvases.create not compliant with API Reference

2 participants

@vegeris @zimeg