fix: add trailing slash to slackApiUrl if none is provided#2243
Merged
WilliamBergamin merged 2 commits intomainfrom May 16, 2025
Merged
fix: add trailing slash to slackApiUrl if none is provided#2243WilliamBergamin merged 2 commits intomainfrom
WilliamBergamin merged 2 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2243 +/- ##
==========================================
+ Coverage 92.65% 92.67% +0.01%
==========================================
Files 38 38
Lines 10527 10554 +27
Branches 677 682 +5
==========================================
+ Hits 9754 9781 +27
Misses 761 761
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
approved these changes
May 15, 2025
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
LGTM! 🚢 💨
This is a nice guard with what's documented so I don't think updates are needed here:
https://tools.slack.dev/node-slack-sdk/web-api#custom-api-url
WilliamBergamin
deleted the
adding-trailing-slash-with-tests-and-edge-cases
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python Slack SDK #1598 introduces changes to ensures that all
base_urlvalues end with a trailing slash, improving URL construction consistency. This PR introduces changes that make the WebClient match this behavior.Requirements (place an
xin each[ ])