oauth(fix): remove double quotes from the default 'add to slack' img alt text#2044
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2044 +/- ##
==========================================
- Coverage 92.51% 91.66% -0.86%
==========================================
Files 37 37
Lines 9981 9981
Branches 631 631
==========================================
- Hits 9234 9149 -85
- Misses 747 820 +73
- Partials 0 12 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I wanted to double check once more that the HTML being updated is invalid and I can confirm this is A double quoted - <img alt=""example"" />
+ <img alt="" />Going to hold off on merging this right now, but I noticed a similar change will also be needed in Bolt for Java 👀 |
|
The failing |
Summary
This PR mirrors the changes contributed in slackapi/bolt-python#1170 🙏
Requirements