Skip to content

Codecov reports should use fully qualified filenames #852

@aoberoi

Description

@aoberoi

Description

Currently when Codecov collects/aggregates coverage reports for a specific change, the reports from several packages collide in a way that makes the aggregations incorrect. For example, both the @slack/web-api and @slack/webhoook packages include a file called src/errors.ts. For Codecov, these are the same file.

There is a separate, but potentially related problem that sometimes the commit SHA that Travis prints out after the coverage report upload does not match the commit SHA from the branch (pull request). When this happens, the PR on GitHub will never receive a status check result. Upon re-running the build, it sometimes will match, and then Codecov's status check will be present.

Related: #851

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions