Skip to content

Set up codecov properly for this repo #838

@aoberoi

Description

@aoberoi

Description

Currently, when tests are run within each package, they run within the context of only that package. That means that all file paths in the coverage report start at the package root. We use a separate flags, which enable us to evaluate changes to coverage in each package separately (this shows up in the PR comments from the codecov bot). However, there are common file heirarchies that create naming conflicts. For example, every package has a src/index.ts, so codecov's report for that filename is meaningless (it acts as a bucket with the mixed report of the src/index.ts from each package). This also means there's no easy way (outside of a PR) to check the overall coverage of a specific package.

Ideally, each package would run nyc from the repo root (as opposed to the package root) so that the file paths no longer overlap. This might also give us the opportunity to remove the duplicated .nycrc.json files from the individual package and have only one in the root. However, the test scripts must provide some means of filtering the included files to only those that matter for the package being tested. Can .nycrc.json files cascade and/or extend one another? Can command line configuration apply over .nycrc.json configuration? Worth looking into.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions