chore(deps-dev): bump tsd from 0.31.2 to 0.32.0 in /packages/web-api (#2236)

dependabot[bot] · mwbrooks · WilliamBergamin · web-flow · commit e2a027520f04 · 2025-04-16T14:48:23.000-07:00
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Brooks <mbrooks@slack-corp.com> Co-authored-by: William Bergamin <wbergamin@slack-corp.com> Co-authored-by: @zimeg <zim@o526.net>
diff --git a/packages/web-api/package.json b/packages/web-api/package.json
@@ -66,7 +66,7 @@
     "sinon": "^20",
     "source-map-support": "^0.5.21",
     "ts-node": "^10",
-    "tsd": "^0.31.1",
+    "tsd": "^0.32.0",
     "typescript": "5.3.3"
   },
   "tsd": {
diff --git a/packages/web-api/src/file-upload.ts b/packages/web-api/src/file-upload.ts
@@ -5,6 +5,7 @@ import type { Logger } from '@slack/logger';
 
 import { ErrorCode, errorWithCode } from './errors';
 import type {
+  FileThreadDestinationArgument,
   FileUploadV2,
   FileUploadV2Job,
   FilesCompleteUploadExternalArguments,
@@ -200,10 +201,10 @@ export async function getFileDataAsStream(readable: Readable): Promise<Buffer> {
 
   return new Promise((resolve, reject) => {
     readable.on('readable', () => {
-      let chunk: Buffer;
-      // biome-ignore lint/suspicious/noAssignInExpressions: being terse, this is OK
-      while ((chunk = readable.read()) !== null) {
+      let chunk = readable.read();
+      while (chunk !== null) {
         chunks.push(chunk);
+        chunk = readable.read();
       }
     });
     readable.on('end', () => {
@@ -240,8 +241,15 @@ export function getAllFileUploadsToComplete(
           channel_id,
           initial_comment,
         };
-        if (thread_ts) {
-          toComplete[compareString].thread_ts = upload.thread_ts;
+        if (thread_ts && channel_id) {
+          const fileThreadDestinationArgument: FileThreadDestinationArgument = {
+            channel_id,
+            thread_ts,
+          };
+          toComplete[compareString] = {
+            ...toComplete[compareString],
+            ...fileThreadDestinationArgument,
+          };
         }
         if ('token' in upload) {
           toComplete[compareString].token = upload.token;
