refactor: derive the request url in a standalone private function

zimeg · WilliamBergamin · zimeg · commit 5f98b568289d · 2025-03-14T14:19:48.000-07:00
Co-authored-by: William Bergamin &lt;wbergamin@salesforce.com&gt;
diff --git a/packages/web-api/src/WebClient.ts b/packages/web-api/src/WebClient.ts
@@ -646,8 +646,7 @@ export class WebClient extends Methods {
     // TODO: better input types - remove any
     const task = () =>
       this.requestQueue.add(async () => {
-        const requestURL =
-          url.startsWith('https' || 'http') && this.allowAbsoluteUrls ? url : `${this.axios.getUri() + url}`;
+        const requestURL = this.deriveRequestUrl(url);
 
         try {
           // biome-ignore lint/suspicious/noExplicitAny: TODO: type this
@@ -740,6 +739,17 @@ export class WebClient extends Methods {
     return pRetry(task, this.retryConfig) as Promise<AxiosResponse<any, any>>;
   }
 
+  /**
+   * Get the complete request URL for the provided URL.
+   * @param url - The resource to POST to. Either a Slack API method or absolute URL.
+   */
+  private deriveRequestUrl(url: string): string {
+    if (url.startsWith('https' || 'http') && this.allowAbsoluteUrls) {
+      return url;
+    }
+    return `${this.axios.getUri() + url}`;
+  }
+
   /**
    * Transforms options (a simple key-value object) into an acceptable value for a body. This can be either
    * a string, used when posting with a content-type of url-encoded. Or, it can be a readable stream, used
