Merged
Conversation
vegeris
commented
Nov 13, 2025
| private String label; | ||
| private Integer value; | ||
| private String link; | ||
| private Icon icon; |
Contributor
Author
There was a problem hiding this comment.
These properties weren't valid for this field type
vegeris
force-pushed
the
feat-work-object-field-types
branch
from
0bb01b2 to
da3240e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
============================================
- Coverage 72.93% 72.89% -0.05%
+ Complexity 4414 4413 -1
============================================
Files 477 477
Lines 14081 14081
Branches 1473 1473
============================================
- Hits 10270 10264 -6
- Misses 2937 2944 +7
+ Partials 874 873 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o feat-work-object-field-types
zimeg
approved these changes
Nov 17, 2025
Comment on lines
+546
to
+547
| EntityPayload.CustomField.builder().type("boolean").key("checkbox").label("Checkbox") | ||
| .value(true).booleanField(BooleanField.builder().type("checkbox").text("Check the box").build()).build() |
Member
There was a problem hiding this comment.
🗳️ praise: Nice improvements to these tests once again!
WilliamBergamin
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the boolean and entity_ref work objects field types, and corrects some properties in the
timestampfield typeCategory (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.