Conversation
zimeg
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
============================================
- Coverage 72.93% 72.92% -0.02%
+ Complexity 4415 4414 -1
============================================
Files 477 477
Lines 14081 14081
Branches 1473 1473
============================================
- Hits 10270 10268 -2
- Misses 2936 2939 +3
+ Partials 875 874 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📫 A few jots for wonderful readers and kind reviewers, as always-
| if (generalChannelId == null) { | ||
| ConversationsListResponse channelsListResponse = | ||
| slack.methods().conversationsList(r -> r.token(botToken).excludeArchived(true).limit(100)); | ||
| slack.methods().conversationsList(r -> r.token(botToken).excludeArchived(true).limit(200)); |
There was a problem hiding this comment.
🏷️ note: Perhaps we revert this? But I changed it because I changed the #general channel of a test workspace I use.
There was a problem hiding this comment.
Since this is in a test we can change it in the future if we ever need to, so I think we can leave it in 💯
| } | ||
| } | ||
|
|
||
| @Ignore // "method_deprecated" 2025-11-12 https://docs.slack.dev/changelog/2025/03/17/files-upload-extension/ |
There was a problem hiding this comment.
📠 note: Today is the day files.upload stop working! I hope we can revisit skipped tests to check for equivalent coverage with filesUploadV2 before removing these tests altogether?
There was a problem hiding this comment.
Great point 💯 I think this should be a teak for when we remove files.upload
| if (generalChannelId == null) { | ||
| ConversationsListResponse channelsListResponse = | ||
| slack.methods().conversationsList(r -> r.token(botToken).excludeArchived(true).limit(100)); | ||
| slack.methods().conversationsList(r -> r.token(botToken).excludeArchived(true).limit(200)); |
There was a problem hiding this comment.
Since this is in a test we can change it in the future if we ever need to, so I think we can leave it in 💯
| } | ||
| } | ||
|
|
||
| @Ignore // "method_deprecated" 2025-11-12 https://docs.slack.dev/changelog/2025/03/17/files-upload-extension/ |
There was a problem hiding this comment.
Great point 💯 I think this should be a teak for when we remove files.upload
|
@WilliamBergamin Kind thanks for the comments and thoughts ahead! I'll merge now for an upcoming release 🚢 💨 |
2 participants
This PR updates the web API client and model based on the production E2E test results - follows #1517.
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.