feat: add webapi response changes as of 2025-10-14#1517
Conversation
zimeg
added
enhancement
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📝 Notes on the changes for the kind reviewer from findings in testing to match the source of truth!
| private boolean ok; | ||
| private String warning; | ||
| private String error; | ||
| private String context; |
There was a problem hiding this comment.
🔍 note: This might appear in responses if an invactive_app error is returned!
| if (!member.isDeleted()) { | ||
| userIds.add(member.getId()); | ||
| } |
There was a problem hiding this comment.
🧪 note: This is added to avoid adding deactivated members to the user group, which can cause error!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
============================================
+ Coverage 73.02% 73.04% +0.02%
- Complexity 4381 4382 +1
============================================
Files 475 475
Lines 14222 14222
Branches 1447 1447
============================================
+ Hits 10385 10388 +3
+ Misses 2980 2976 -4
- Partials 857 858 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mwbrooks I share your excitement for these checks so I will merge this 👾 Hoping to investigate scheduled updates in neartimes so we can remain current across the SDKs - IIRC some of these values are useful in building |
2 participants
This PR updates the web API client and model based on the production E2E test results - follows #1504.
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.