feat: Centralize and expose a registerTypeAdapters method on GsonFactory#1510
Merged
WilliamBergamin merged 3 commits intoslackapi:mainfrom Oct 1, 2025
Merged
Conversation
|
Thanks for the contribution! Before we can merge this, we need @luanpotter to sign the Salesforce Inc. Contributor License Agreement. |
luanpotter
changed the title
WilliamBergamin
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
============================================
- Coverage 73.12% 73.04% -0.09%
+ Complexity 4384 4381 -3
============================================
Files 475 475
Lines 14245 14222 -23
Branches 1447 1447
============================================
- Hits 10417 10388 -29
- Misses 2969 2976 +7
+ Partials 859 858 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WilliamBergamin
approved these changes
Oct 1, 2025
Contributor
Author
|
@WilliamBergamin my pleasure! and thank you so much for the swift review 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize and expose a
registerTypeAdaptersmethod onGsonFactoryTypically on larger projects,
gsonneeds to be configured with many other adapters and configurations. The way theGsonFactoryclass onslack-api-clientcurrently expose a finalized, pre-builtgsoninstances makes it less reusable for users, who would have to copy the adapter registration configuration one-by-one if they already have agsonof their own.In fact, even within
GsonFactory, the code is already repeated thrice, which can lead to desynchronization issues - which, in fact, did happen, as the last version had two repeated registrations (MessageChangedEvent.PreviousMessageandLogsResponse.DetailsChangedValue) and two missing registrations (FunctionExecutedEvent.InputValue,Attachment.VideoHtml), clearly a copy-paste mistake (unless this was intentional, but the reason would most certainly elude me).This unifies all instances to use the same shared method, and expose it so users can create their own instances as well.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.