docs: update release instructions#1440
Merged
WilliamBergamin merged 7 commits intoslackapi:mainfrom Jun 16, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
============================================
+ Coverage 73.06% 73.09% +0.02%
- Complexity 4381 4382 +1
============================================
Files 475 475
Lines 14244 14244
Branches 1447 1447
============================================
+ Hits 10408 10412 +4
+ Misses 2977 2974 -3
+ Partials 859 858 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seratch
approved these changes
Feb 17, 2025
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Thanks! I've added additional information about the signing process prep.
.github/maintainers_guide.md
Outdated
| * Make sure there are no build failures at https://github.com/slackapi/java-slack-sdk/actions | ||
| * Set a new version | ||
| * If you don't have `gnu-sed`, run `brew install gnu-sed` first | ||
| * If you don't have `gnu-sed`, run `brew install gnu-sed` & `brew install gnupg` first |
Contributor
There was a problem hiding this comment.
Just installing GnuPG is not enough. Before making the release, there are a few steps to complete:
- Set up your key: https://central.sonatype.org/publish/requirements/gpg/
- Make sure if your account has the permission to make releases under com.slack groupId (note that this page requires login as the account)
- Update your $HOME/.m2/settings.xml
- generate user token: https://central.sonatype.org/publish/generate-token/
- set the user token id/password: https://central.sonatype.org/publish/publish-manual/#signing-components
Contributor
Author
There was a problem hiding this comment.
Good point I moved this to prerequisites 💯
mwbrooks
approved these changes
Jun 13, 2025
Member
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Everything reads well and the instructions are clear. I've left one minor suggestion on formatting, but it's a non-blocker.
Co-authored-by: Michael Brooks <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to update the release instructions in the maintainers guide
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.