Add #1416 Add expand property to SectionBlock class#1420
Add #1416 Add expand property to SectionBlock class#1420seratch merged 2 commits intoslackapi:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1420 +/- ##
============================================
+ Coverage 73.23% 73.26% +0.03%
- Complexity 4369 4370 +1
============================================
Files 474 474
Lines 14182 14185 +3
Branches 1433 1433
============================================
+ Hits 10386 10393 +7
+ Misses 2952 2947 -5
- Partials 844 845 +1 ☔ View full report in Codecov by Sentry. |
|
The generated constructors for I'm guessing the intention is to strictly use the builder / DSL pattern, in which case should the auto generated constructors have a different access modifier? |
|
Thanks for letting us know this. Indeed, the all-arg constructor is different now. If this kind of change affects your project, please consider using the builder pattern rather than the all-arg constructor. Whenever the Slack platform adds a new property to a block class, this project will continue making this kind of change. Sorry for the disruption you've encountered but it'd be appreciated if you could understand this. |
This pull request resolves #1416
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.