Add conversations.requestSharedInvite.list API support#1382
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
============================================
+ Coverage 74.52% 74.55% +0.02%
- Complexity 4324 4329 +5
============================================
Files 472 472
Lines 13491 13506 +15
Branches 1377 1378 +1
============================================
+ Hits 10054 10069 +15
+ Misses 2624 2623 -1
- Partials 813 814 +1 ☔ View full report in Codecov by Sentry. |
seratch
added
enhancement
seratch
force-pushed
the
shared-invite-list-sample
branch
from
e6c0ee2 to
353521f
Compare
Contributor
|
@filmaj Thanks for working on this! I've completed the remaining changes and needed adjustment! |
seratch
changed the title
conversations.requestSharedInvite.list response sample logconversations.requestSharedInvite.list API support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @seratch & @WilliamBergamin
We will need to add support soon for this API: https://api.slack.com/methods/conversations.requestSharedInvite.list
This closely relates to #1365
This document shows the necessary requirements in terms of Slack plan (enterprise grid) and settings (specific enterprise Slack Connect settings): https://api.slack.com/automation/governing-slack-connect-invites
Once you have the above set up, then when a non-admin / non-owner user (this part tripped me up!) sends a Slack Connect invite, you can use the
listAPI to then list out these to-be-approved SC invites. I tested this out by having a regular grid user open up a channel's settings -> Settings tab -> Slack Connect invite.@seratch this PR is definitely insufficient to add support for this API to the java SDK - my apologies. When I have a moment, I will review past PRs that added new APIs to this repo and copy the approach. If you have any additional pointers for this, let me know and I can address it tomorrow. In the mean time, this PR at least unblocks me from getting a PR for this API ready in the node-slack-sdk repo. EDIT: I've added some more to this PR but I am still missing the
ListResponseclass; since the response structure is a bit more complicated than the simple cases, I am not sure how to exactly proceed - your guidance would be appreciated. Feel free to push to this PR if it's something you can address directly easier, too.